Skip to content

LSP-Plugin: Add MPP support #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nepet wants to merge 11 commits into
base: master
Choose a base branch
from
Open

LSP-Plugin: Add MPP support #8948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a9a84f0
plugins(lsps2): add session FSM for LSPS2 payment collection
nepet Mar 18, 2026
7f1259c
plugins(lsps2): add session actor with action executor boundary
nepet Mar 18, 2026
119a54a
plugins(lsps2): add session manager and unify HTLC handling
nepet Mar 18, 2026
baf58d7
plugins(lsps2): add integration tests for session lifecycle
nepet Mar 18, 2026
a012bf5
plugins(lsps2): add restart recovery for session persistence
nepet Mar 18, 2026
416ed58
plugins(lsps2): simplify DatastoreProvider to focused trait
nepet Mar 18, 2026
b6f872f
plugins(lsps2): add EventSink trait for session event notification
nepet Mar 18, 2026
05e4a82
plugins(lsps2): decouple lsps2 crate from CLN-specific types
nepet Mar 18, 2026
f764c2b
plugins(lsps2): simplify actor and session manager
nepet Mar 18, 2026
72194d2
plugins(lsps2): make collect timeout dev config
nepet Mar 19, 2026
da925c6
plugins(lsps2): route recovered sessions through forward_event path
nepet Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions plugins/lsps-plugin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,29 @@ edition = "2021"
[[bin]]
name = "cln-lsps-client"
path = "src/client.rs"
required-features = ["cln"]

[[bin]]
name = "cln-lsps-service"
path = "src/service.rs"
required-features = ["cln"]

[features]
default = ["cln"]
cln = ["cln-plugin", "cln-rpc"]

[dependencies]
anyhow = "1.0"
async-trait = "0.1"
bitcoin = "0.32.2"
bitcoin = { version = "0.32", features = ["serde"] }
chrono = { version= "0.4.42", features = ["serde"] }
cln-plugin = { workspace = true }
cln-rpc = { workspace = true }
cln-plugin = { workspace = true, optional = true }
cln-rpc = { workspace = true, optional = true }
hex = "0.4"
log = "0.4"
paste = "1.0.15"
rand = "0.9"
serde = { version = "1.0", features = ["derive"] }
serde_json = { version = "1.0", features = ["raw_value"] }
thiserror = "2.0"
tokio = { version = "1.44", features = ["full"] }
tokio = { version = "1.44", features = ["full", "test-util"] }
12 changes: 5 additions & 7 deletions plugins/lsps-plugin/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ use cln_lsps::{
transport::{MultiplexedTransport, PendingRequests},
},
proto::{
lsps0::{Msat, LSPS0_MESSAGE_TYPE, LSP_FEATURE_BIT},
lsps0::{Msat, LSP_FEATURE_BIT},
lsps2::{compute_opening_fee, Lsps2BuyResponse, Lsps2GetInfoResponse, OpeningFeeParams},
},
};
use cln_plugin::{options, HookBuilder, HookFilter};
use cln_plugin::options;
use cln_rpc::{
model::{
requests::{
Expand Down Expand Up @@ -82,10 +82,7 @@ impl ClientState for State {
#[tokio::main]
async fn main() -> Result<(), anyhow::Error> {
if let Some(plugin) = cln_plugin::Builder::new(tokio::io::stdin(), tokio::io::stdout())
.hook_from_builder(
HookBuilder::new("custommsg", hooks::client_custommsg_hook)
.filters(vec![HookFilter::Int(i64::from(LSPS0_MESSAGE_TYPE))]),
)
.hook("custommsg", hooks::client_custommsg_hook)
.option(OPTION_ENABLED)
.rpcmethod(
"lsps-listprotocols",
Expand Down Expand Up @@ -485,7 +482,7 @@ async fn on_lsps_lsps2_invoice(
// 5. Approve jit_channel_scid for a jit channel opening.
let appr_req = ClnRpcLsps2Approve {
lsp_id: req.lsp_id,
jit_channel_scid: buy_res.jit_channel_scid,
jit_channel_scid: buy_res.jit_channel_scid.into(),
payment_hash: public_inv.payment_hash.to_string(),
client_trusts_lsp: Some(buy_res.client_trusts_lsp),
};
Expand Down Expand Up @@ -698,6 +695,7 @@ async fn on_openchannel(
return Ok(serde_json::json!({
"result": "continue",
"mindepth": 0,
"reserve": 0,
Copy link
Member

@cdecker cdecker Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this will break megalithic LSP? They do not have a way to set no reserve.

}));
} else {
// Not a requested JIT-channel opening, continue.
Expand Down
5 changes: 5 additions & 0 deletions plugins/lsps-plugin/src/cln_adapters/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@ pub mod rpc;
pub mod sender;
pub mod state;
pub mod types;

pub use rpc::{
ClnActionExecutor, ClnDatastore, ClnPolicyProvider, ClnRecoveryProvider,
ClnRpcClient,
};
Loading
Loading