Skip to content

Fix tess-expandable behaviour when multiple under the same parent e… #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbacall merged 3 commits into from
Feb 18, 2026
Merged

Fix tess-expandable behaviour when multiple under the same parent e… #1234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cebbbb
Fix `tess-expandable` behaviour when multiple under the same parent e…
fbacall Feb 12, 2026
a278f05
Fix broken/multiple events firing due to Turbolinks
fbacall Feb 12, 2026
2937932
Update app/assets/javascripts/application.js
fbacall Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions app/assets/javascripts/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,9 @@ document.addEventListener("turbolinks:load", function(e) {
LearningPaths.init();

$('.tess-expandable').each(function () {
if (this.dataset.origHeight) {
return;
}
var limit = this.dataset.heightLimit || 300;

if (this.clientHeight > limit) {
Expand All @@ -286,32 +289,11 @@ document.addEventListener("turbolinks:load", function(e) {
this.dataset.origHeight = this.clientHeight;
this.style.maxHeight = '' + limit + 'px';
this.classList.add('tess-expandable-closed');
var btn = $('<a href="#" class="tess-expandable-btn">Show more</a>');
const btn = $('<a href="#" class="tess-expandable-btn">Show more</a>');
btn.insertAfter($(this));
}
});

$(document).on('click', '.tess-expandable-btn', function (event) {
event.preventDefault();
var div = this.parentElement.querySelector('.tess-expandable');
var maxHeight = parseInt(div.dataset.origHeight) + 80;
var limit = parseInt(div.dataset.heightLimit || "300");

if (div.classList.contains('tess-expandable-closed')) {
div.classList.add('tess-expandable-open');
div.classList.remove('tess-expandable-closed');
div.style.maxHeight = '' + maxHeight + 'px';
this.innerHTML = 'Show less';
} else {
div.classList.remove('tess-expandable-open');
div.classList.add('tess-expandable-closed');
div.style.maxHeight = '' + limit + 'px';
this.innerHTML = 'Show more';
}

return false;
});

$('.faq .question dt').click(function () {
var button = $(this).find('.expand');
var sign = button.text();
Expand Down Expand Up @@ -380,6 +362,36 @@ $(document).on('click', '[href="#activity_log"]', function () {
return false;
});

$(document).on('click', '.tess-expandable-btn', function (event) {
event.preventDefault();
let div = this.previousElementSibling;

if (!div || !div.classList.contains('tess-expandable')) {
div = this.parentElement.querySelector('.tess-expandable');
}

if (!div) {
return false;
}

const maxHeight = parseInt(div.dataset.origHeight) + 80;
const limit = parseInt(div.dataset.heightLimit || "300");

if (div.classList.contains('tess-expandable-closed')) {
div.classList.add('tess-expandable-open');
div.classList.remove('tess-expandable-closed');
div.style.maxHeight = '' + maxHeight + 'px';
this.innerHTML = 'Show less';
} else {
div.classList.remove('tess-expandable-open');
div.classList.add('tess-expandable-closed');
div.style.maxHeight = '' + limit + 'px';
this.innerHTML = 'Show more';
}

return false;
});

// sticky-navbar feature
document.addEventListener('turbolinks:load', function () {

Expand Down