Enable fast WOSAC evals on large datasets with resampling#280
Merged
daphne-cornelisse merged 13 commits into2.0from Feb 6, 2026
Merged
Enable fast WOSAC evals on large datasets with resampling#280daphne-cornelisse merged 13 commits into2.0from
daphne-cornelisse merged 13 commits into2.0from
Conversation
…keep puffer code clean).
JinkaiQiu
pushed a commit
to JinkaiQiu/PufferDrive
that referenced
this pull request
Feb 26, 2026
…#280) * Improve random map resampling code. * Refactor env: Create separate resampling function. * Works with wosac_use_map_as_resampling_target = False. * More elegant and clean solution to map resampling. * Clean up. * Put batch iteration in the WOSACEvaluator class to avoid repetition (keep puffer code clean). * Improve naming. * Clean up code and drop duplicates. * Fix util functions so that we can run wosac during training. * Log more metrics to wandb. * Remove unused variable map_idex. * Fix human replay eval. * Drop last scenario from batch as a safety measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When evaluating WOSAC on large datasets, the current implementation loads all target scenes into memory simultaneously, leading to excessive memory consumption and potential out-of-memory errors.
Solution
This PR refactors the evaluation pipeline to iterate through datasets incrementally, loading and processing scenes one at a time rather than all at once.
Usage
Implentation