Skip to content

Overviewpage multistore#131

Merged
ahuininga-orisha merged 10 commits intodevelopfrom
feat-overviewpage-multistore
Apr 24, 2026
Merged

Overviewpage multistore#131
ahuininga-orisha merged 10 commits intodevelopfrom
feat-overviewpage-multistore

Conversation

@ahuininga-orisha
Copy link
Copy Markdown
Collaborator

This adds the ability to change an overviewpage for sprecific store views. So you can add translations etc.

Fixes #121

@jansentjeu
Copy link
Copy Markdown
Collaborator

@ahuininga-orisha Do you have test scenarios for me to test this in the admin?

@ahuininga-orisha
Copy link
Copy Markdown
Collaborator Author

@jansentjeu

  • Create an overviewpage in the admin
  • Edit the overview page
  • Switch to an different storview while editing
  • change the url (and other data)
  • Save the changes for that specific storeview.
  • Check on the frontend if the overview page works for that storeview on that url, and you see the changes made for that storeview
  • Check if the overviewpage works in the frontend for other storeviews with the orginal data.

Copy link
Copy Markdown
Collaborator

@jansentjeu jansentjeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the beta branch into this branch? Then you can run vendor/bin/grumphp run --ansi. It will run the new code checks

Comment thread src/Controller/OverviewPage/View.php
Comment thread src/Model/OverviewPage.php Outdated
Comment thread src/Model/OverviewPage.php
Comment thread src/Model/OverviewPage/DataProvider.php
Comment thread src/Model/ResourceModel/OverviewPage.php
Comment thread src/Model/UrlRewriteService.php
Comment thread src/Setup/Patch/Data/ConvertOverviewpageEntries.php
Comment thread src/Model/OverviewPage.php Outdated
Comment thread src/Model/OverviewPageRepository.php
Copy link
Copy Markdown
Collaborator

@jansentjeu jansentjeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuininga-orisha Did you test the latest changes? When i run setup:upgrade i get an error message.

@ahuininga-orisha ahuininga-orisha force-pushed the feat-overviewpage-multistore branch from 2a68868 to cc77924 Compare March 20, 2026 09:04
@ahuininga-orisha
Copy link
Copy Markdown
Collaborator Author

@jansentjeu Rebased on the current beta en resolved merge conflict. Should be working now.

Comment thread src/Model/UrlRewriteService.php
Comment thread src/Model/UrlRewriteService.php Outdated
Comment thread src/Setup/Patch/Data/ConvertOverviewpageEntries.php
Comment thread src/Setup/Patch/Data/ConvertOverviewpageEntries.php Outdated
ahuininga-orisha added 2 commits March 25, 2026 15:25
@ahuininga-orisha ahuininga-orisha changed the base branch from beta to develop April 23, 2026 11:50
@ahuininga-orisha ahuininga-orisha merged commit 6fb5f7c into develop Apr 24, 2026
1 check passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 6.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants