Draft
Conversation
It seems the magic which converts `README.md` paths to `index.html` doesn't work here, because the generated path is to a non-existent `README.html`.
86743c2 to
4505241
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 55 55
Lines 7626 7626
Branches 7626 7626
=======================================
Hits 6675 6675
Misses 649 649
Partials 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
90899ec to
237de2b
Compare
tsmbland
approved these changes
Feb 25, 2026
tsmbland
reviewed
Feb 25, 2026
| \\( \sum_t act_t \\). | ||
|
|
||
| [overall MUSE2 workflow]: ./README.md#framework-overview | ||
| [framework-overview]: https://energysystemsmodellinglab.github.io/MUSE2/model/index.html#framework-overview |
Collaborator
There was a problem hiding this comment.
Why do we have to use a URL here rather than an internal link?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The link checker workflow is currently not working, which is causing other open PRs to fail CI checks.
There are a few reasons:
docs/model/investment.mderased-serdecrate that are linked to from our API docs, even though it should be generated automatically. Not sure what the problem is, but I've just ignored these for now.book/404.htmlfile, which is also autogenerated, so I'm just ignoring the file nowThe link checker workflow doesn't actually run on pushes to
main. We are checking that the docs build ok, as part of the docs deployment workflow, but maybe we should also check links here too.Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks