Open
Conversation
More professional!
|
I am a bit worried about these primitive booleans. I think we should implement a proper internal wrapper and construct them with a factory. |
Author
|
defo should box and unbox them 🤦 |
|
LGTM 👍 |
radrow
suggested changes
Jul 21, 2024
radrow
left a comment
radrow
left a comment
There was a problem hiding this comment.
As mentioned earlier on, primitive booleans are not considered best industry practice. Please implement a proper boolean-based decision making framework with strategies, adapters and factories. Otherwise you are just contributing to the technical debt with little company or customer benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More professional!