Remove stale artifacts (hdbscan-benchmark, unused fixture)#137
Open
gvonness-apolitical wants to merge 1 commit intomainfrom
Open
Remove stale artifacts (hdbscan-benchmark, unused fixture)#137gvonness-apolitical wants to merge 1 commit intomainfrom
gvonness-apolitical wants to merge 1 commit intomainfrom
Conversation
hdbscan-benchmark.ts imports hdbscan-ts which is not a project dependency — the @ts-ignore masks a MODULE_NOT_FOUND runtime error. labeled-pairs.json in test/fixtures/ is unreferenced; the experiment scripts read from corpus/labeled-pairs.json instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/benchmarks/hdbscan-benchmark.ts— importshdbscan-tswhich is not a project dependency;@ts-ignoremasks the MODULE_NOT_FOUND runtime errortest/fixtures/labeled-pairs.json— unreferenced by any.tsfile; experiment scripts read fromcorpus/labeled-pairs.json(gitignored, generated) insteadscripts/ops/recluster-fast.tsis unaffected (uses Python subprocess, not hdbscan-ts)Test plan
npm run buildpassesnpm test— all 2053 tests passnpm run lint— zero errors, zero warnings