Open
Conversation
Collaborator
Oh, sorry, there are more! |
Szelethus
reviewed
Jan 30, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
I suppose we should fix the issues pylint found, and then merge.
furtib
force-pushed
the
linting
branch
2 times, most recently
from
39e4e97 to
a8a02c3
Compare
Szelethus
reviewed
Feb 5, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Can we add this to test/test.sh?
Szelethus
reviewed
Feb 5, 2026
|
|
||
| The following additional modules the ones found in the [README](README.md) are needed for the development: | ||
|
|
||
| # Optional modules |
Contributor
There was a problem hiding this comment.
Maybe we should add pylint here as well
Contributor
Author
There was a problem hiding this comment.
It is there???
module add python/3.11-addons-pylint-2.14.5
This is because all warnings are things that should be addressed by the developer using the template, and not fixed in the template itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
To enforce coding standards
What:
self.assertTrue(True)or setUp methods are considered issues by pylint, while they are just unfinished)Note:
requirements.txt.Addresses:
Fixes: #153