Open
Conversation
Szelethus
reviewed
Apr 2, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
I think the most correct solution would be to make CodeChecker the single source of authority on how to do skipping. For instance, CodeChecker would-skip mytest.cpp --skip skipfile.txt could return 0/1. On the other hand... this is quite an established interface we are extremely unlikely to ever change.
@bruntib, can you throw in your two cents?
Szelethus
reviewed
Apr 7, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
We had an intersting coversation WRT older CC versions. If we patch this CodeChecker-side, it would be more elegant and robust, and wouldn't need much (any?) bazel side changes. However, that would cement skip files not working for per-file analysis with older CC versions. We should consider this carefully.
furtib
force-pushed
the
skipfile-for-per-file-python
branch
2 times, most recently
from
d494901 to
50f5b0c
Compare
furtib
force-pushed
the
skipfile-for-per-file-python
branch
from
50f5b0c to
1bb58db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
There is no skipfile option for the per_file rule.
We should strive to solve this on the Bazel side, but in the meanwhile it is okay if we just create an empty plist file for skipped files.
What:
Addresses:
Fixes: #160