Create a unit_test macro for tests that assert on output files#213
Open
furtib wants to merge 13 commits intoEricsson:mainfrom
Open
Create a unit_test macro for tests that assert on output files#213furtib wants to merge 13 commits intoEricsson:mainfrom
furtib wants to merge 13 commits intoEricsson:mainfrom
Conversation
Allow accepting multiple files Remove incorrect help (we cannot check log files of failing tests)
Since tests are not being invoked from a python file anymore we need to run bazel test //...
furtib
force-pushed
the
test_into_bazel_001
branch
from
01027e4 to
3013225
Compare
nettle
reviewed
Apr 7, 2026
Collaborator
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
I like the idea!
However I would consider not mixing python tests and bazel tests.
But as a prototype it is definitely good!
And, as @Szelethus mentioned, we need a strategy for bazel tests.
And... please dont touch legacy tests - I need them as the reference!
Comment on lines
+36
to
+37
| "//test/unit:unit_test.bzl", | ||
| "unit_test", |
Collaborator
There was a problem hiding this comment.
Please dont touch "my" legacy tests so far :)
Contributor
Author
There was a problem hiding this comment.
Okay, I will revert them.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| exports_files(["grep_check.py"]) |
Collaborator
There was a problem hiding this comment.
I guess this should not be needed
Contributor
Author
I'm completely lost as to what this means. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to integrate our tests into Bazel.
What:
Addresses:
#210