Open
Conversation
Szelethus
reviewed
Sep 2, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
I want to give some credit, because this really is a novel and clever solution. I just happen not to prefer it to --ccache-skip, because we can't guarantee that ccache will be in the PATH, especially if its only used during build configuration (this is not made up, its a legitimate usecase). Can we not just do that, and keep it in tools.bzl?
furtib
force-pushed
the
ccache-repository-rule
branch
2 times, most recently
from
e963809 to
02e217b
Compare
Contributor
Author
|
I have tried my best to reproduce the behaviour you describe. Since we cannot use custom flags, I have resorted to using environment variables. I have decided to pass the CCACHE_DISABLE=1 flag to the jobs. Please test if it works on your machine! |
furtib
force-pushed
the
ccache-repository-rule
branch
from
02e217b to
56c9a9d
Compare
furtib
force-pushed
the
ccache-repository-rule
branch
from
3eac5bc to
c81d553
Compare
This reverts commit c430ce5.
furtib
force-pushed
the
ccache-repository-rule
branch
from
c81d553 to
581e572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Bazel and ccache don't work well together. We should warn the user that their analyzers use ccache and fail the job to force the user to disable ccache (by changing package_layout.json or uninstalling ccache)
What:
Extended the repository rule that detects CodeChecker to also detect ccache
Addresses:
Fixes #36