Open
Conversation
Verify compatibility of reflectasm with newer jdks.
Because 1.5 is no longer supported by jdk 9+
Collaborator
Author
|
Build with jdk 11 failed once with Rebuilding was successful. |
|
Will this solve the issue with future deprecation warnings when using Java 9+? (#64) |
|
@MartenTrustly Was hoping that too, but I don't think so judging by the code and @magro own suggestion in that ticket:
@NathanSweet Any chance of getting this merged and #64 fixed? |
Collaborator
Author
|
Exactly, this here will not remove the depreciation warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify compatibility of reflectasm with newer jdks.
Jdk 9+ requires to change the source/target version from 1.5 to 1.6.
I've not verified this locally, let's use travis for validation.