Conversation
Ayantea1
reviewed
Feb 13, 2026
tests.py
Outdated
| assert len(collector.get_books_genre()) == 2 | ||
|
|
||
| def test_add_new_book_name_more_40_symbols_not_added(self): | ||
| collector = BooksCollector() |
There was a problem hiding this comment.
Можно улучшить: общее для всех тестов предусловие можно вынести в фикстуру
Ayantea1
reviewed
Feb 13, 2026
tests.py
Outdated
| collector.add_new_book('Оно') | ||
| collector.set_book_genre('Оно', 'Ужасы') | ||
|
|
||
| assert collector.get_book_genre('Оно') == 'Ужасы' |
There was a problem hiding this comment.
Нужно исправить: для get_book_genre должен быть отдельный тест. Тесты не должны дублировать друг друга. В идеале - чтобы в каждом тесте использовался только один проверяемый метод, все остальное можно получить прямым доступом к словарям и спискам
Ayantea1
reviewed
Feb 13, 2026
tests.py
Outdated
| collector.add_new_book('Оно') | ||
| collector.add_book_in_favorites('Оно') | ||
|
|
||
| assert collector.get_list_of_favorites_books() == ['Оно'] |
There was a problem hiding this comment.
Нужно исправить: для получения списка избранного тоже нужен отдельный тест
Ayantea1
reviewed
Feb 13, 2026
tests.py
Outdated
|
|
||
|
|
||
| class TestBooksCollector: | ||
| @pytest.fixture |
There was a problem hiding this comment.
Можно улучшить: лучше хранить в отдельном модуле
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.