Skip to content

handle finish and error events to avoid dead _flush loop#112

Open
hellolwq wants to merge 1 commit intoEvanOxfeld:masterfrom
xunleif2e:master
Open

handle finish and error events to avoid dead _flush loop#112
hellolwq wants to merge 1 commit intoEvanOxfeld:masterfrom
xunleif2e:master

Conversation

@hellolwq
Copy link

samples.zip

sample zip files will cause unzip in dead _flush loop, handle the error and finish events can avoid this.

@ZJONSSON
Copy link

fyi, your sample file works with an active fork unzipper

const request = require('request');
const unzipper = require('unzipper');

request('https://github.com/EvanOxfeld/node-unzip/files/1678258/samples.zip')
  .pipe(unzipper.Parse())
  .on('entry', entry => entry.autodrain())
  .promise()
  .then( () => console.log('done'), e => console.log('error',e));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants