Add Transitioning check to DelayAltMusic in Level.LoadLevel#1061
Add Transitioning check to DelayAltMusic in Level.LoadLevel#1061maddie480 merged 2 commits intoEverestAPI:devfrom
Conversation
|
i don't really understand the impact of the bug here. can you provide examples of reproduction steps with expected vs actual behaviour? |
Reproduction steps:
Expected behaviour: Actual behaviour: |
|
oh yeah, should we tell the Celeste developers about this? it is a bug in the base game after all |
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
to preface, rooms have an additional attribute called
delayAltMusicFade(in Lönn, it's aliased todelayAlternativeMusicFade), which works with the room's alt music (set with thealt_musicattribute, which in Lönn is aliased tomusicAlternative).when alt music is played, the main music is muted. so in order to be heard, alt music has to be routed differently to main music. the base game has them routed to
music/tunes/side_rooms.the value of
delayAltMusicFadeis assigned to theLevelData'sDelayAltMusicfield, which is a boolean that determines at which moment to play or stop the alt music.if it's
false, as it is by default, the alt music is played or stopped as soon as the room is loaded.if it's
true, then that is delayed for when the transition into the next room is complete.currently, due to an oversight, the
truesetting makes it only work during room transitions.so what happens when you "Save and Quit" from that room, and then load the save again and return to it?
the main music will play, but the alt music won't, until you enter the room again via transition.
this PR attempts to fix this by adding a check for whether the level's transitioning routine is being played.
a base game example of an alt music room with the delay enabled is the secret room in Chapter 6.
for comparison, an example of an alt music room without the delay is Theo's camp in Chapter 1.