Skip to content

Deprecate unused flags#1068

Merged
maddie480 merged 2 commits intoEverestAPI:devfrom
DashingCat:deprecate-unused-flags
Mar 8, 2026
Merged

Deprecate unused flags#1068
maddie480 merged 2 commits intoEverestAPI:devfrom
DashingCat:deprecate-unused-flags

Conversation

@DashingCat
Copy link
Copy Markdown
Contributor

This PR deprecates the following flags and removes associated usages:

  • AvoidRenderTargets
  • PreferLazyLoading
  • SupportRuntimeMods
  • SupportUpdatingEverest

These flags are unused as far as I can tell.

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jan 11, 2026
Copy link
Copy Markdown
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the dialog key EVERESTUPDATER_NOTSUPPORTED in the dialog files?

@DashingCat
Copy link
Copy Markdown
Contributor Author

Should we also remove the dialog key EVERESTUPDATER_NOTSUPPORTED in the dialog files?

Yes, I missed this in the first commit, the last commit removes it.

@maddie480-bot
Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Mar 8, 2026, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Mar 1, 2026
@maddie480-bot
Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Mar 8, 2026
@maddie480 maddie480 merged commit 0e6cbed into EverestAPI:dev Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants