Respect mute preference for iOS foreground notification sounds by MobileMage · Pull Request #82045 · Expensify/App

MobileMage · 2026-02-10T20:37:35Z

Explanation of Change

When the "Mute all sounds from Expensify" preference is enabled, iOS foreground push notifications still play a sound. This fix checks the mute preference in the setForegroundPresentationOptionsCallback and, when muted, explicitly returns only List, Banner, and Badge presentation options (omitting Sound), instead of returning null which uses the default presentation (which includes sound).

Fixed Issues

$ #81282
PROPOSAL: #81282 (comment)

Tests

Log into the app on a physical iOS device
Go to Settings > Troubleshoot > toggle on "Mute all sounds from Expensify"
Have another user send you a message while the app is in the foreground
Verify the notification banner appears but no sound plays
Toggle off "Mute all sounds from Expensify"
Have another user send you a message again
Verify the notification banner appears with sound

Verify that no errors appear in the JS console

Offline tests

N/A - This change only affects iOS foreground push notification presentation options, which require an active network connection to receive.

QA Steps

Log into the app on a physical iOS device
Go to Settings > Troubleshoot > toggle on "Mute all sounds from Expensify"
Have another user send you a message while the app is in the foreground
Verify the notification banner appears but no sound plays
Toggle off "Mute all sounds from Expensify"
Have another user send you a message again
Verify the notification banner appears with sound

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-10T20:37:42Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MobileMage · 2026-02-10T20:39:15Z

Would need a build triggered to test this one as it's done with push notifications.

codecov · 2026-02-10T20:43:46Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...hNotification/ForegroundNotifications/index.ios.ts	`54.54% <16.66%> (-45.46%)`	⬇️
... and 439 files with indirect coverage changes

eh2077 · 2026-02-11T09:20:58Z

@MobileMage Can you try this method to mock a push notification to the simulator?

MobileMage · 2026-02-11T09:32:58Z

Hey @eh2077 I don't have access to the Slack channel yet.

eh2077 · 2026-02-11T09:36:27Z

I see, please check below then

Does it have to be on a physical device? On the simulator you can send a notification with:
xcrun simctl push DEVICEID com.expensify.chat.dev AlertPushNotification.apns

AlertPushNotification.apns
{
  "Simulator Target Bundle": "com.expensify.chat.dev",
  "aps": {
    "alert": "Testing",
    "sound": "default",
    "badge": 1,
  },
  "payload": "{\"reportID\":\"1234\"}"
}

eh2077 · 2026-02-13T11:13:11Z

@MobileMage friendly bump! Can you also add unit tests for the change please?

JmillsExpensify

Recently discussed in Slack. It's a good change in line with product spec.

When 'Mute all sounds from Expensify' is toggled on, iOS foreground notifications still played sound because the presentation options callback always returned the defaults (including Sound). Now checks getIsMuted() and excludes Sound from presentation options when muted. Fixes Expensify#81282

github-actions · 2026-02-13T21:17:22Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2026-02-13T21:17:38Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

MobileMage · 2026-02-13T21:23:09Z

Sorry about the force push, I had accidentally merged main into the branch which bloated the PR to 1500+ commits. The force push just removed that merge commit — no actual changes were lost.

MobileMage · 2026-02-13T21:28:21Z

I've also added unit tests for the change.

@eh2077 I did try the xcrun simctl push method but it didn't work for this case. The simulated push notification only showed up when the app was in the background. When the app was open and in the foreground, the notification didn't come through. The behavior we're testing here is specifically about foreground notifications when someone sends you a message and you're in app so the in app sound doesn't play, the APNS simulation wasn't useful for that. But the unit tests should cover the mute logic well.

eh2077 · 2026-02-17T11:59:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MobileMage requested review from a team as code owners February 10, 2026 20:37

melvin-bot bot assigned MobileMage Feb 10, 2026

melvin-bot bot requested review from JmillsExpensify and eh2077 and removed request for a team February 10, 2026 20:37

melvin-bot bot removed the request for review from a team February 10, 2026 20:37

JmillsExpensify previously approved these changes Feb 13, 2026

View reviewed changes

MobileMage added 2 commits February 13, 2026 20:45

Add unit tests for iOS foreground notification mute preference

a89b6d1

MobileMage dismissed JmillsExpensify’s stale review via aa9bc5f February 13, 2026 21:17

MobileMage requested review from a team and stephanieelliott as code owners February 13, 2026 21:17

MobileMage force-pushed the fix/81282-mute-notification-sound branch from aa9bc5f to a89b6d1 Compare February 13, 2026 21:20

stephanieelliott removed their request for review February 16, 2026 22:32

Conversation

MobileMage commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 10, 2026

Uh oh!

MobileMage commented Feb 10, 2026

Uh oh!

codecov bot commented Feb 10, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eh2077 commented Feb 11, 2026

Uh oh!

MobileMage commented Feb 11, 2026

Uh oh!

eh2077 commented Feb 11, 2026

Uh oh!

eh2077 commented Feb 13, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MobileMage commented Feb 13, 2026

Uh oh!

MobileMage commented Feb 13, 2026

Uh oh!

eh2077 commented Feb 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MobileMage commented Feb 10, 2026 •

edited

Loading

codecov bot commented Feb 10, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading