[CP Staging] fix/82727-82739-revert-workspace-list-accessibility#82749
Merged
MarioExpensify merged 3 commits intoExpensify:mainfrom Feb 18, 2026
Merged
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
heyjennahay
and removed request for
a team
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f89267fafa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
aimane-chnaif
left a comment
aimane-chnaif
left a comment
There was a problem hiding this comment.
I suggest fully revert changes in WorkspacesListRow
Contributor
Author
Hey @aimane-chnaif Could you elaborate this one, Please? Thanks 🙏 |
Contributor
Minimal & safe changes as this should be CP'ed, |
Contributor
Author
|
Ok |
TaduJR
changed the title
TaduJR
changed the title
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariBefore fix: Screen.Recording.2026-02-18.at.10.13.31.am.movAfter fix: Screen.Recording.2026-02-18.at.10.12.24.am.mov |
aimane-chnaif
approved these changes
Feb 18, 2026
Contributor
aimane-chnaif
left a comment
aimane-chnaif
left a comment
There was a problem hiding this comment.
Confirmed
- fixes both blockers
- 2 file changes are exact revert of original PR
MarioExpensify
approved these changes
Feb 18, 2026
Contributor
|
Thank you @TaduJR for acting quickly. |
Contributor
|
🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
MarioExpensify
changed the title
7 tasks
OSBotify
pushed a commit
that referenced
this pull request
Feb 18, 2026
…-Element-Focusable fix/82727-82739-revert-workspace-list-accessibility (cherry picked from commit ee59dc5) (cherry-picked to staging by mountiny)
93 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.21-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.22-0 🚀
|
This was referenced Feb 19, 2026
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR fully reverts the accessibility changes to
WorkspacesListRow.tsxandWorkspacesListPage.tsxintroduced in PR #80450Fixed Issues
$ #82727
$ #82739
$ #82721
PROPOSAL:
Tests
Deploy Blocker #82727 — Column Alignment
Deploy Blocker #82739 — Arrow Click
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Mac-Chrome.mov