Skip to content

Fix deleted transaction selection mode#86789

Closed
luacmartins wants to merge 1 commit intomainfrom
cmartins-ifxDeleteSelection
Closed

Fix deleted transaction selection mode#86789
luacmartins wants to merge 1 commit intomainfrom
cmartins-ifxDeleteSelection

Conversation

@luacmartins
Copy link
Copy Markdown
Contributor

@luacmartins luacmartins commented Mar 31, 2026 •
edited
Loading

Explanation of Change

Fixes the deleted transaction selection callback

Fixed Issues

$ #86780

Tests

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Create an expense.
  4. Delete the expense.
  5. Go to Reports > Expenses.
  6. Click Status, select Deleted and click Apply.
  7. Long tap on the expense > Select.
  8. Tap on the expense row.
  9. Verify that you can select/unselect the transaction
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-03-31.at.3.20.05.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@luacmartins luacmartins self-assigned this Mar 31, 2026
@luacmartins luacmartins marked this pull request as ready for review March 31, 2026 21:20
@luacmartins luacmartins requested review from a team as code owners March 31, 2026 21:20
@melvin-bot melvin-bot bot requested review from mananjadhav and trjExpensify and removed request for a team and trjExpensify March 31, 2026 21:20
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 31, 2026

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 31, 2026 21:20
@luacmartins luacmartins mentioned this pull request Mar 31, 2026
Closed
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...Search/SearchList/ListItem/TransactionListItem.tsx 0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 329479f949

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Search/SearchList/ListItem/TransactionListItem.tsx
ref={pressableRef}
onLongPress={() => onLongPressRow?.(item)}
onPress={isDeletedTransaction ? undefined : () => onSelectRow(item, transactionPreviewData)}
onPress={isDeletedTransaction && !canSelectMultiple ? undefined : () => onSelectRow(item, transactionPreviewData)}
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict deleted-row taps to active selection mode

This condition uses canSelectMultiple as a proxy for selection mode, but canSelectMultiple is always true on large screens (src/components/Search/index.tsx:1189), so deleted transactions become pressable on desktop. When tapped there, onSelectRow does not toggle selection (that only happens in mobile selection mode) and instead proceeds with normal navigation logic (src/components/Search/index.tsx:1031-1038), which re-enables opening deleted rows that were previously intentionally non-interactive.

Useful? React with 👍 / 👎.

@luacmartins
Copy link
Copy Markdown
Contributor Author

luacmartins commented Mar 31, 2026

hmm there are multiple blockers related to this PR so I think we might just revert it.

@luacmartins luacmartins removed the request for review from mananjadhav March 31, 2026 21:37
@jasperhuangg
Copy link
Copy Markdown
Contributor

jasperhuangg commented Apr 1, 2026

approving in case we wind up moving back to this

@luacmartins
Copy link
Copy Markdown
Contributor Author

luacmartins commented Apr 1, 2026

We reverted the offending PR, so this is no longer needed.

@luacmartins luacmartins closed this Apr 1, 2026
@jnowakow
Copy link
Copy Markdown
Contributor

jnowakow commented Apr 2, 2026

It will be merged to #86938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@luacmartins luacmartins

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luacmartins @jasperhuangg @jnowakow