Skip to content

[HOLD] Show "Undelete" action in expanded group search results in wide view#86867

Closed
mhawryluk wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:fix/search-expanded-group-action
Closed

[HOLD] Show "Undelete" action in expanded group search results in wide view#86867
mhawryluk wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:fix/search-expanded-group-action

Conversation

@mhawryluk
Copy link
Copy Markdown
Contributor

@mhawryluk mhawryluk commented Apr 1, 2026

Explanation of Change

Display an "Undelete" action button instead of "View" in the transaction rows shown after expanding a group in Search on a non-narrow view. Also hides the right arrow button in that case. Refactors useUndeleteTransactions to accept transactions and not depend on useAllTransactions as per-group results are fetched separately and stored outside of the current search snapshot.

Fixed Issues

$ #86796
PROPOSAL: N/A

Tests

(Web wide view only)

  1. Create a couple expenses and delete them.
  2. Open Reports tab.
  3. Search for expenses, selecting status:deleted and group-by:<something>
  4. Display the "Action" column by selecting it in Columns (or typing in columns:action in the query)
  5. Click on a group to expand it.
  6. Verify the deleted expenses show an "Undelete" button under the Action column.
  7. Click on it. Verify undeleting works.
  8. Select some expenses' checkboxes.
  9. Click on "n selected" > Undelete
  10. Verify that it works.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-04-1.o.13.22.22.mov

(narrow view)
Zrzut ekranu 2026-04-1 o 14 24 50

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ts/Search/SearchList/ListItem/ActionCell/index.tsx 68.42% <100.00%> (+1.75%) ⬆️
...h/SearchList/ListItem/ExpenseReportListItemRow.tsx 0.00% <ø> (ø)
...earch/SearchList/ListItem/ReportListItemHeader.tsx 97.14% <ø> (ø)
...h/SearchList/ListItem/TransactionGroupListItem.tsx 70.83% <ø> (ø)
...SearchList/ListItem/UserInfoAndActionButtonRow.tsx 100.00% <ø> (ø)
src/components/Search/SearchList/index.tsx 43.96% <100.00%> (ø)
src/hooks/useSearchBulkActions.ts 0.00% <ø> (ø)
src/hooks/useUndeleteTransactions.ts 50.00% <100.00%> (ø)
src/styles/index.ts 49.00% <ø> (ø)
...archList/ListItem/TransactionGroupListExpanded.tsx 67.27% <50.00%> (+0.60%) ⬆️
... and 3 more
... and 83 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@jnowakow jnowakow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mhawryluk mhawryluk changed the title Show "Undelete" action in expanded group search results Show "Undelete" action in expanded group search results in wide view Apr 1, 2026
@mhawryluk mhawryluk marked this pull request as ready for review April 1, 2026 12:38
@mhawryluk mhawryluk requested review from a team as code owners April 1, 2026 12:38
@melvin-bot melvin-bot bot requested review from ahmedGaber93 and heyjennahay and removed request for a team April 1, 2026 12:38
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 1, 2026

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mhawryluk
Copy link
Copy Markdown
Contributor Author

mhawryluk commented Apr 1, 2026

@Expensify/design does it look okay? ("Undelete" button in place of "View", no right arrow)

Zrzut ekranu 2026-04-1 o 14 46 11

also for context: all the other expense statuses have "View" action, which doesn't work for deleted expenses. we don't show the action column on narrow view at all.

@dannymcclain
Copy link
Copy Markdown
Contributor

Can we double-check the width of the button to make sure it's the same size as all our other buttons that show up there? The alignment on the action column looks a little weird there.

Also @Expensify/design I personally feel like Undelete should be a regular, gray button, not a green button, but curious for your thoughts!

@mhawryluk
Copy link
Copy Markdown
Contributor Author

Can we double-check the width of the button to make sure it's the same size as all our other buttons that show up there? The alignment on the action column looks a little weird there.

the button has the same width as when it's in a regular row (not inside an expanded group):

Zrzut ekranu 2026-04-1 o 14 58 30

should it be different? I don't think we show any buttons like these in the expanded group view currently

@shawnborton
Copy link
Copy Markdown
Contributor

I think what Danny is saying is that maybe the left side of the Amount column header isn't lining up with the cell below? Let's check those widths in this area:
CleanShot 2026-04-01 at 15 25 15@2x

I also like the idea of using a regular style button for Undelete.

@dannymcclain
Copy link
Copy Markdown
Contributor

Yes thank you for clarifying Shawn, I should've been more descriptive!

@mhawryluk mhawryluk requested a review from a team as a code owner April 1, 2026 14:54
@mhawryluk
Copy link
Copy Markdown
Contributor Author

I think the issue was not with the action button width, but rather with the header right padding (not taking into account right arrow's padding, 4px were missing), I modified it and I think it's fixed:

Zrzut ekranu 2026-04-1 o 16 50 11 Zrzut ekranu 2026-04-1 o 16 49 46

@luacmartins luacmartins changed the title Show "Undelete" action in expanded group search results in wide view [HOLD] Show "Undelete" action in expanded group search results in wide view Apr 1, 2026
@dannymcclain
Copy link
Copy Markdown
Contributor

Yeah I think that's looking pretty good.

@shawnborton
Copy link
Copy Markdown
Contributor

Send it!

@jnowakow
Copy link
Copy Markdown
Contributor

jnowakow commented Apr 2, 2026

It will be merged to It will be merged to #86938. You guys for taking care of it! ❤️

@jnowakow jnowakow closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants