Manual expense flow UI refactor r2#86923
Manual expense flow UI refactor r2#86923ChavdaSachin wants to merge 12 commits intoExpensify:mainfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b93809afeb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04a2701c18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Known bugs: (to be handled in next PR, added to to do list)
|
Explanation of Change
This PR is 2nd release of UI improvements for Expense/IOU creation flow, which aims to replace a few push row inputs with inline inputs to improve UX for migrate users.
The new flow is walled behind
newManualExpenseFlow.Current PR refactored Fields
MerchantandDescriptionto be inline input along with addressing previous blockers listed below.Previous blockers:
#86342
#86394
#86351
Fixed Issues
$ #82586
PROPOSAL: NA
Tests
Test 1
+from composer -> Create expense -> Manual.MerchantandDescription.MerchantandDescriptionfields are editable.create expensebutton.Field Requirederror pops up for merchant field.create expensebutton.Test 2
+from composer -> Create expense -> Manual.MerchantandDescription.MerchantandDescriptionfields are editable.create expensebutton.MerchantandDescriptionvalues.create expensebutton.+from composer -> Split expense -> Manual.Offline tests
Same as tests.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Precondition: Log in with Expensifail account.
Test 1
+from composer -> Create expense -> Manual.MerchantandDescription.MerchantandDescriptionfields are editable.create expensebutton.Field Requirederror pops up for merchant field.create expensebutton.Test 2
+from composer -> Create expense -> Manual.MerchantandDescription.MerchantandDescriptionfields are editable.create expensebutton.MerchantandDescriptionvalues.create expensebutton.+from composer -> Split expense -> Manual.Previous Blocker : #86342
Previous Blocker: #86394
Note: Mobile device only test
Previous Blocker: #86351
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-02.at.9.23.14.AM.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-02.at.9.18.46.AM.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-02.at.7.42.57.AM.mov