BT - Migrate TASK_TITLE, REPORT_DESCRIPTION#86941
BT - Migrate TASK_TITLE, REPORT_DESCRIPTION#86941mananjadhav wants to merge 4 commits intoExpensify:mainfrom
TASK_TITLE, REPORT_DESCRIPTION#86941Conversation
melvin-bot
bot
requested review from
huult and
trjExpensify
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 698c0258a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| Navigation.navigate(ROUTES.TASK_TITLE.getRoute(report?.reportID, Navigation.getReportRHPActiveRoute())); | ||
| Navigation.navigate(ROUTES.TASK_TITLE.getRoute(report?.reportID)); |
There was a problem hiding this comment.
Navigating to ROUTES.TASK_TITLE.getRoute(report?.reportID) always builds r/:reportID/title, so the title page no longer knows whether it was opened from Search/Expense/other modal report contexts. Because TaskTitlePage now derives back navigation from the current URL, pressing Back from those contexts resolves to r/:reportID instead of returning to the originating route, which is a regression from the prior backTo behavior.
Useful? React with 👍 / 👎.
src/pages/ReportDetailsPage.tsx
Outdated
| shouldCheckActionAllowedOnPress={false} | ||
| description={translate('reportDescriptionPage.roomDescription')} | ||
| onPress={() => Navigation.navigate(ROUTES.REPORT_DESCRIPTION.getRoute(report.reportID, Navigation.getActiveRoute()))} | ||
| onPress={() => Navigation.navigate(ROUTES.REPORT_DESCRIPTION.getRoute(report.reportID))} |
There was a problem hiding this comment.
This now navigates to the absolute path r/:reportID/description from Report Details, which drops the details context. RoomDescriptionPage computes its back target by stripping /description, so Back lands on r/:reportID instead of r/:reportID/details, pulling users out of the Details flow. Using a dynamic suffix route here is needed to preserve the correct return path.
Useful? React with 👍 / 👎.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
trjExpensify
left a comment
trjExpensify
left a comment
There was a problem hiding this comment.
backTo project PR 👍
2 participants
Explanation of Change
Fixed Issues
$ #83371
PROPOSAL:
Tests
Task title (r/:reportID/title)
Report / task description (r/:reportID/description)
Observe the URL ending with /description after the report segment (e.g. r//description).
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-bt-task-title-desc.mov
Android: mWeb Chrome
mweb-chrome-bt-task-title-desc.mov
iOS: Native
ios-bt-task-title-desc.mov
iOS: mWeb Safari
mweb-safari-bt-task-title-desc.mov
MacOS: Chrome / Safari
web-bt-task-title-desc.mov