Remove canBeMissing option from Onyx#734
Conversation
|
@mountiny @tgolen PR opened to review. Here is the E/App PR where I'm removing all Please check if it's acceptable to merge a PR like that. If not, we will need to re-think the strategy here. |
mountiny
left a comment
There was a problem hiding this comment.
I think the package lock json diff is not needed here.
I think we can merge it as it should be quite straightforward BUT we should make the the onyx bump does not have other changes.
There was a problem hiding this comment.
It has been a while since I noticed that doing npm install on main is always updating package-lock.json, so I assume someone forgot to do it in a past PR and I decided to fix it here.
Totally agree. At the moment E/App is using
|
Details
This PR removes all references to
canBeMissingin Onyx.Proposal: https://expensify.slack.com/archives/C08CZDJFJ77/p1770828347278359
E/App PR: Expensify/App#82467
Related Issues
Expensify/App#80095
Automated Tests
Related tests to
canBeMissingare being removed.Manual Tests
There are no behavior changes in E/App, so just a general test:
Author Checklist
### Related Issuessection aboveTestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-13.at.21.24.22-compressed.mov
Android: mWeb Chrome
Screen.Recording.2026-02-13.at.21.29.37-compressed.mov
iOS: Native
Screen.Recording.2026-02-13.at.21.34.33-compressed.mov
iOS: mWeb Safari
Screen.Recording.2026-02-13.at.21.37.58-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-13.at.21.39.51-compressed.mov
Screen.Recording.2026-02-13.at.21.41.10-compressed.mov
MacOS: Desktop
N/A