Skip to content

fix: fail orphaned batch parents instead of leaving processing jobs#627

Merged
chubes4 merged 1 commit intomainfrom
fix/batch-parent-stuck-processing-624
Mar 5, 2026
Merged

fix: fail orphaned batch parents instead of leaving processing jobs#627
chubes4 merged 1 commit intomainfrom
fix/batch-parent-stuck-processing-624

Conversation

@chubes4
Copy link
Member

@chubes4 chubes4 commented Mar 5, 2026

Summary

  • mark parent batch jobs as failed when batch transient state is missing instead of leaving them in processing
  • fail parent batches when final chunk completes but zero child jobs were actually scheduled
  • add unit coverage for both failure paths in PipelineBatchSchedulerTest

Why

On events.extrachill.com, parent jobs could remain in processing despite Action Scheduler actions completing. This change adds explicit terminal states for orphaned/empty batch paths so queue state stays truthful and scalable.

Testing

  • homeboy test data-machine --skip-lint --path=\"/var/lib/datamachine/workspace/data-machine\" -- --filter \"PipelineBatchSchedulerTest|ToolResultFinderTest\"

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Homeboy Results — data-machine

Tooling versions

  • Homeboy CLI: homeboy 0.56.0
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: unknown
  • Action: Extra-Chill/homeboy-action@v1

ℹ️ PR test scope resolved to full for compatibility with installed Homeboy CLI

lint (changed files only)

  • PHPCS: LINT SUMMARY: 4 errors, 9 warnings
  • Fixable: 8 | Files with issues: 1 of 1
  • PHPStan: PHPSTAN SUMMARY: 133 errors at level 5

Homeboy Action v1 — homeboy 0.56.0

@chubes4 chubes4 force-pushed the fix/batch-parent-stuck-processing-624 branch from 4d342b2 to ca86705 Compare March 5, 2026 14:55
@chubes4 chubes4 merged commit 1f7df06 into main Mar 5, 2026
2 checks passed
@chubes4 chubes4 deleted the fix/batch-parent-stuck-processing-624 branch March 5, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant