fix: include schedule and max_items in flows list output#629
Merged
Conversation
5896015 to
1b49fa6
Compare
Homeboy Results —
|
1b49fa6 to
b0a1a12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleandmax_itemscolumns towp datamachine flows listdefault outputschedulefrom each flow'sscheduling_config(including cron expressions)max_itemsfrom handler configs inflow_configand surface ashandler=max_itemspairsWhy
datamachine/get-flowsalready returns scheduling and handler config data, but the CLI list view hid it. This made it hard to audit manual schedules andmax_itemswithout runningflows getper flow.Validation
php -l inc/Cli/Commands/Flows/FlowsCommand.php