Skip to content

fix: support multiple payload-types #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FDj wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: support multiple payload-types #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd9005a
Fix audio payload type extraction logic
FDj Jan 13, 2026
bb1163b
Refactor comments for audio payload-type logic
FDj Jan 13, 2026
3e93324
Improve audio payload type handling
FDj Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,25 @@ export class Connection {
}

const audio = this.endpointDescription.audio;
const audioPayloadType = audio['payload-type'];

// For some versions of interconnected components we may receive an array of payload-types
// instead of a single payload-type. We pick the one that's opus, if present, or the first,
// and otherwise proceed as before:

let audioPayloadType = audio['payload-type'];

if (!audioPayloadType?.id) {
const audioPayloadTypes = audio['payload-types'];
if (!Array.isArray(audioPayloadTypes) || audioPayloadTypes.length === 0) {
throw new Error(
`endpointDescription.audio.payload-types missing/empty: ${JSON.stringify(audio)}`
);
}

// Prefer opus if present, else first
audioPayloadType =
audioPayloadTypes.find((pt: { name?: string }) => pt?.name?.toLowerCase() === 'opus');
}

for (const element of this.mediaStreams.audio.ssrcs) {
const audioDescription = this.makeMediaDescription('audio');
Expand Down