Skip to content

Fix textures with 518 pixel size#7065

Closed
BlackYps wants to merge 2 commits intodevelopfrom
fix/texture-bug
Closed

Fix textures with 518 pixel size#7065
BlackYps wants to merge 2 commits intodevelopfrom
fix/texture-bug

Conversation

@BlackYps
Copy link
Copy Markdown
Contributor

@BlackYps BlackYps commented Mar 22, 2026

Description of the proposed changes

Some textures in the ancient earth env folder had a size of 518 instead of 512. This throws the map editor off and probably causes a rescale by the game when it loads these textures. Both are bad side-effects, so I rescaled the textures.

Testing done on the proposed changes

None

Checklist

Summary by CodeRabbit

  • Bug Fixes
    • Fixed texture scaling to improve visual consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

📝 Walkthrough

Walkthrough

A new changelog snippet file was added documenting a texture scaling adjustment. The entry notes that textures with 518 pixel size were scaled to 512 pixels.

Changes

Cohort / File(s) Summary
Changelog Entry
changelog/snippets/fix.7065.md
Added new changelog snippet documenting texture scaling fix from 518px to 512px.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A changelog hop, so small and bright,
Textures trimmed from 518 to right,
Just 512 pixels in a single line,
Documentation complete, the fix is fine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing textures that have an incorrect 518 pixel size by rescaling them to 512 pixels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description covers the main sections with clear problem statement and testing disclosure, though one non-critical section is unfilled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/texture-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot marked this pull request as draft March 22, 2026 18:38
@BlackYps BlackYps marked this pull request as ready for review April 10, 2026 15:34
@BlackYps BlackYps requested review from 4z0t and Basilisk3 April 10, 2026 15:34
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
changelog/snippets/fix.7065.md (1)

1-1: Consider adding more context to the changelog entry.

While the current entry is accurate, it could be more informative by mentioning which textures are affected (ancient earth environment) and why this matters (prevents map editor issues and runtime rescaling overhead).

✨ Example enhancement
-- (`#7065`) Scale some textures with 518 pixel size to 512.
+- (`#7065`) Scale ancient earth environment textures from 518 to 512 pixels to prevent map editor issues and runtime rescaling.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@changelog/snippets/fix.7065.md` at line 1, The changelog entry "Scale some
textures with 518 pixel size to 512." lacks context—update this line to specify
which textures and why: mention the affected textures (ancient earth
environment) and the rationale (prevents map editor issues and avoids runtime
rescaling overhead), e.g., expand the sentence to note the specific asset group
and the benefit to editor/runtime performance so readers understand scope and
impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@changelog/snippets/fix.7065.md`:
- Line 1: Add a trailing newline at the end of the file containing the line "-
(`#7065`) Scale some textures with 518 pixel size to 512." so the file ends with a
single newline character (POSIX convention); simply edit the file and ensure the
final byte is a newline without changing the existing content.

---

Nitpick comments:
In `@changelog/snippets/fix.7065.md`:
- Line 1: The changelog entry "Scale some textures with 518 pixel size to 512."
lacks context—update this line to specify which textures and why: mention the
affected textures (ancient earth environment) and the rationale (prevents map
editor issues and avoids runtime rescaling overhead), e.g., expand the sentence
to note the specific asset group and the benefit to editor/runtime performance
so readers understand scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 389485ba-ec11-4028-9ae4-c1dd4bd2a1cd

📥 Commits

Reviewing files that changed from the base of the PR and between 947ec80 and 1d4c06d.

⛔ Files ignored due to path filters (3)
  • env/Ancient-Earth/props/clutter/eg_bush01_normalsTS.dds is excluded by !**/*.dds
  • env/Ancient-Earth/props/clutter/eg_bush02_normalsTS.dds is excluded by !**/*.dds
  • env/Ancient-Earth/props/clutter/eg_bush03_normalsTS.dds is excluded by !**/*.dds
📒 Files selected for processing (1)
  • changelog/snippets/fix.7065.md

@@ -0,0 +1 @@
- (#7065) Scale some textures with 518 pixel size to 512. No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add trailing newline at end of file.

The file does not end with a newline character, which is a common convention (POSIX standard) and helps with cleaner diffs and compatibility with various text processing tools.

📝 Proposed fix
 - (`#7065`) Scale some textures with 518 pixel size to 512.
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- (#7065) Scale some textures with 518 pixel size to 512.
- (`#7065`) Scale some textures with 518 pixel size to 512.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@changelog/snippets/fix.7065.md` at line 1, Add a trailing newline at the end
of the file containing the line "- (`#7065`) Scale some textures with 518 pixel
size to 512." so the file ends with a single newline character (POSIX
convention); simply edit the file and ensure the final byte is a newline without
changing the existing content.

@BlackYps
Copy link
Copy Markdown
Contributor Author

Closed in favor of #6982 lel

@BlackYps BlackYps closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant