Skip to content

binapigen: fix type sizes for Unions and BaseTypes #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sknat merged 1 commit into from
Apr 16, 2026
+7 −8
Merged

binapigen: fix type sizes for Unions and BaseTypes #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions binapigen/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,8 @@ func getFieldType(g *GenFile, field *Field) string {

func getUnionSize(union *Union) (maxSize int) {
for _, field := range union.Fields {
if size, isBaseType := getSizeOfField(field); isBaseType {
logrus.Panicf("union %s field %s has unexpected type %q", union.Name, field.Name, field.Type)
} else if size > maxSize {
size, _ := getSizeOfField(field)
if size > maxSize {
maxSize = size
}
}
Expand All @@ -152,16 +151,16 @@ func getSizeOfField(field *Field) (size int, isBaseType bool) {
size = getUnionSize(union)
return
}

// Reaching here is indication of being a BaseType.
size = getSizeOfBinapiBaseType(field.Type, field.Length)

return size, true
}

func getSizeOfStruct(typ *Struct) (size int) {
for _, field := range typ.Fields {
fieldSize, isBaseType := getSizeOfField(field)
if isBaseType {
size += getSizeOfBinapiBaseType(field.Type, field.Length)
continue
}
fieldSize, _ := getSizeOfField(field)
size += fieldSize
}
return size
Expand Down
Loading