CI: Enforce SPDX headers on newly changed files#5268
CI: Enforce SPDX headers on newly changed files#5268crueter wants to merge 1 commit intoFEX-Emu:mainfrom
Conversation
crueter
force-pushed
the
reuse
branch
3 times, most recently
from
93c31cf to
e180104
Compare
|
CC. this requires |
neobrain
left a comment
neobrain
left a comment
There was a problem hiding this comment.
Honestly this is an awful lot of code for a relatively small problem. I don't think we need to automate the adding of SPDX headers.
For checking presence of the headers, is there no existing tooling that does this?
|
Unfortunately no, REUSE has a command-line interface but it just doesn't work right. I can rework the existing code into something a bit more compact by removing the add/update code. |
Just the identifier, year can be easily retrofitted by changing one variable. This script will receive updates in the future, so can be implanted when those occur. Not sure if retroactively applying headers is a good idea, but that would be a separate PR. Signed-off-by: crueter <crueter@eden-emu.dev>
|
OK, consolidated it a bit |
|
I'm still not sure this solves a problem we had. It's not a ton of code, but the cost of missing an SPDX header now and then is equally marginal. Maybe others want to weigh in on this. |
|
I'm just going to say no to this. It's CI for the sake of CI rather than actually solving a problem. Good shout that some projects probably need this but I don't think that's us. |
3 participants
Just the identifier, year can be easily retrofitted by changing one
variable. This script will receive updates in the future, so can be
implanted when those occur.
Not sure if retroactively applying headers is a good idea, but that
would be a separate PR.
Signed-off-by: crueter crueter@eden-emu.dev