expand recipe Iodine* to iodine resource/water/*#170
Open
fchichorro wants to merge 1 commit intoFLCAC-admin:masterfrom
Open
expand recipe Iodine* to iodine resource/water/*#170fchichorro wants to merge 1 commit intoFLCAC-admin:masterfrom
fchichorro wants to merge 1 commit intoFLCAC-admin:masterfrom
Conversation
Flow Iodine | resource/water | kg has no CFs on FEDEFL's recipe. In ecoinvent, the equivalent flow's (Iodine, in water | natural resource/in water | kg) CFs come from recipe flowable Iodine*, which has CFs for mineral resource scarcity only. FEDEFL currently expands Iodine* to resource/ground, but not to resource/water. I suggest making it expand to resource/water also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEDEFL Flow
Iodine | resource/water | kghas no CFs on FEDEFL's recipe. In ecoinvent, the equivalent flow's (Iodine, in water | natural resource/in water | kg) CFs come from recipe flowable Iodine*, which has CFs for mineral resource scarcity only. FEDEFL currently expands Iodine* to resource/ground, but not to resource/water. I suggest making it expand to resource/water/* also (I added all possible target contexts to the mapping).@ErCollao @ganorris