Skip to content

Bugfix/allow recovering from reset with busy connections #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasPoehler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/allow recovering from reset with busy connections #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aced55
FIX: Try to establish new connection when dataSource is down
jonasPoehler Feb 24, 2025
08c971c
Better fix
jonasPoehler Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnectionQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,10 @@ private PooledConnection _obtainConnection() throws InterruptedException, SQLExc
// or SQLException but that is ok as its only an indicator
hitCount++;
// are other threads already waiting? (they get priority)
if (waitingThreads == 0) {
if (waitingThreads == 0
// If datasource is down, we might run into _obtainConnectionWaitLoop forever (or until no thread requests connections),
// in case threads were waiting when reset() occurs. Without this, it would be hard to recover/reconnect the pool.
|| busyList.size() < maxSize) {
PooledConnection freeConnection = extractFromFreeList();
if (freeConnection != null) {
return freeConnection;
Expand Down