fix: make health_checks optional in service deployment module

[srikxcipher]

Description

The health_checks is not required by the 3_utility/application/ helm chart template. The template guards probe generation with hasKey checks and uses default values throughout - missing health_checks simply results in no probes configured, which is a valid deployment state.

deployment.yaml line 198–199:
  {{- if ( hasKey .Values.spec.runtime "health_checks") }}
      {{- include "app-chart.liveness-readiness-check" . | nindent 8 }}

Note: The entire probe block is skipped if health_checks is absent. No probes = valid deployment.

Related issues

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• I have created feat/bugfix branch out of develop branch
• Code passes linting/formatting checks
• Changes to resources have been tested in our dev environments
• I have made corresponding changes to the documentation

Testing

Reviewer instructions

Summary by CodeRabbit

• Improvements
  • Health checks are now optional when configuring deployments and stateful services, allowing services to be deployed without mandatory health check specifications and providing greater flexibility in deployment scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7b42b93f-8943-424f-b1f3-9ddb312dab10

📥 Commits

Reviewing files that changed from the base of the PR and between 2847764 and 8213b6f.

📒 Files selected for processing (1)

• modules/service/statefulset/0.1/facets.yaml

💤 Files with no reviewable changes (1)

• modules/service/statefulset/0.1/facets.yaml

---

Walkthrough

Removed health_checks from the spec.required lists in two facets schemas (deployment and statefulset). The health_checks field remains present in UI ordering but is no longer mandatory during spec validation.

Changes

Cohort / File(s)	Summary
Service facets schemas modules/service/deployment/0.1/facets.yaml, modules/service/statefulset/0.1/facets.yaml	Deleted health_checks from spec.required, making the field optional while keeping it in x-ui-order. No other schema structure or ordering changes.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: making health_checks optional in the service deployment module, which aligns with the changeset modifications to both deployment and statefulset facets.yaml files.
Description check	✅ Passed	The description includes a clear rationale explaining why health_checks should be optional, references the helm chart template behavior, and completes the required template sections including type of change and relevant checklist items.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/service-health-checks-optional

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.