Skip to content

Restrict ACK ACM controller IAM to read-only#523

Closed
sanmesh-kakade wants to merge 2 commits intodevelopfrom
fabric-fixes
Closed

Restrict ACK ACM controller IAM to read-only#523
sanmesh-kakade wants to merge 2 commits intodevelopfrom
fabric-fixes

Conversation

@sanmesh-kakade
Copy link
Contributor

Summary

  • Remove IAM permissions that allow creating, importing, deleting, renewing, or modifying ACM certificates (RequestCertificate, ImportCertificate, DeleteCertificate, RenewCertificate, ExportCertificate, UpdateCertificateOptions)
  • Retain only read and tag management permissions needed for adopting existing certs via AdoptedResource
  • Enforces least-privilege access for the ACK ACM controller

Test plan

  • Deploy updated module and verify ACK controller can adopt an existing ACM cert via AdoptedResource
  • Verify controller can sync cert to Kubernetes Secret via exportTo
  • Confirm RequestCertificate is denied (no new certs can be created)

🤖 Generated with Claude Code

Remove permissions that allow creating, importing, deleting, renewing,
or modifying ACM certificates. The controller now only needs to adopt
and sync existing certificates via AdoptedResource.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • facets-saas

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71e22f9c-1314-4841-bba0-517e22494363

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fabric-fixes
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Required for exportTo to work with adopted certificates. This permission
only reads existing cert data (cert body + private key), does not create
new certificates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sanmesh-kakade
Copy link
Contributor Author

covered in #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant