Skip to content

Remove the depracated warning when using gconfig.C#1011

Draft
karabowi wants to merge 3 commits intoFairRootGroup:devfrom
karabowi:gconfig_fix
Draft

Remove the depracated warning when using gconfig.C#1011
karabowi wants to merge 3 commits intoFairRootGroup:devfrom
karabowi:gconfig_fix

Conversation

@karabowi
Copy link
Collaborator

@karabowi karabowi commented Sep 15, 2020

Use the FairVMCConfig in the simulation macros.

Addresses issue #1010.

Checklist:

[ X ] Rebased against dev branch
[ X ] My name is in the resp. CONTRIBUTORS/AUTHORS file
[ X ] Followed the seven rules of great commit messages

@karabowi karabowi force-pushed the gconfig_fix branch 8 times, most recently from 5986b68 to b9c0dad Compare September 23, 2020 09:04
@dennisklein dennisklein added this to the v19.0 milestone Mar 8, 2021
@dennisklein
Copy link
Member

dennisklein commented Mar 8, 2021

Please rebase on current dev, thx!

@dennisklein dennisklein marked this pull request as draft March 8, 2021 16:16
@dennisklein dennisklein linked an issue Mar 8, 2021 that may be closed by this pull request
[WARN] FairGenericVMCConfig::Setup() Using gConfig.C macro DEPRACATED. #1010
Open
@karabowi karabowi force-pushed the gconfig_fix branch 2 times, most recently from 3715d06 to 453ab6c Compare April 22, 2021 10:07
@dennisklein dennisklein marked this pull request as ready for review July 23, 2021 13:43
dennisklein
dennisklein previously approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@dennisklein dennisklein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty and removed the commits that added and removed stuff (with the netto result of doing nothing). Also rebased to dev and renamed one commit from Add missing library to Tune MQ pixelDetector example output.

@dennisklein dennisklein force-pushed the gconfig_fix branch 3 times, most recently from 7c189ff to 453ab6c Compare July 24, 2021 23:07
dennisklein
dennisklein reviewed Jul 24, 2021
View reviewed changes
Copy link
Member

@dennisklein dennisklein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted my changes, because the PR turned out not quite ready for merging.

  • See inline comments
  • Please clean the commits from changes that are introduced and again removed within this PR.
  • Two following commits have the same commit message, but one of them does not match the changes, please reword more appropriately.

(once done, press the button "Ready for review" at the bottom of this page right above the CI checks list)

examples/MQ/pixelDetector/macros/run_sim.C Outdated
// ----- Create simulation run ----------------------------------------
FairRunSim* run = new FairRunSim();
run->SetName(mcEngine); // Transport engine
run->SetSimulationConfig(new FairVMCConfig());
Copy link
Member

@dennisklein dennisklein Jul 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FairVMCConfig object appears to be leaking (not going to repeat this comment for the other places in this PR).

@dennisklein dennisklein marked this pull request as draft July 24, 2021 23:45
@ChristianTackeGSI
Copy link
Member

ChristianTackeGSI commented Jun 24, 2022

The centos 7 CI tests fail, because they don't have yaml-cpp installed.

As Dennis already pointed out, we should get clear on how this should be handled?

@ChristianTackeGSI
Copy link
Member

ChristianTackeGSI commented Jun 27, 2022

Next step: Memory management.

If SetSimulationConfig gets an owning pointer (as all the proposed examples do), FairRunSim should clean up that memory.

My proposal would be to perform the same steps as for Sink/Source:
Use a unique_ptr inside FairRunSim, provide a new (additional) SetSimulationConfig API that also takes a unique_ptr, and rewrite the examples accordingly.
See for examples on how this could look like: #1194, #1200

@karabowi
Remove the depracated warning about using gconfig.C
db5050e 
Use the FairVMCConfig in the simulation macros.

Addresses issue FairRootGroup#1010.
@karabowi
Apply fixes after rebasing
61fb012 
Added yaml-cpp requirement to main CMakeLists.
Changed include order in Tutorial1 macro.
Removed endl from LOG(info) in FairYamlVMCConfig.
@karabowi
Use unique pointers for the simulation config
2c0dd25 
Changes the FairGenericVMCConfig and FairRunSim,
as well as macros/files using the config.
@dennisklein dennisklein modified the milestones: v19.0, v19.2 Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will not be closed.

@github-actions github-actions bot added the Stale label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisklein dennisklein dennisklein left review comments

@ChristianTackeGSI ChristianTackeGSI ChristianTackeGSI left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

[WARN] FairGenericVMCConfig::Setup() Using gConfig.C macro DEPRACATED.

3 participants

@karabowi @dennisklein @ChristianTackeGSI