call toJSON only AFTER this.replacer#45
Open
michele-nuzzi wants to merge 1 commit intoFaleij:masterfrom
Open
Conversation
replacer needs to be called before `toJSON`. example when encoding `Buffer` I'd like to receive hex strings, but instead `toJSON` is called and my replacer is not called on `Buffer`s
Owner
|
I understand why you want this but the original implementation of JSON.stringify by Douglas Crockford and the implementation that is in all browsers follows the convention of calling toJSON before the replacer function, that's why this library follows that convention as well. I will accept a pull request that changes this behavior depending on an argument to JsonStreamStringify so that it does not break the original behavior. Example of this behavior in chromium browsers: < JSON.stringify({ toJSON() { return 'toJSON'; }}, (k, v) => {
console.log({ k, v });
return v;
})
> {k: '', v: 'toJSON'} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacer needs to be called before
toJSON.example when encoding
BufferI'd like to receive hex strings, but insteadtoJSONis called and my replacer is not called onBuffers