Fix _finishLongTextAscii returning negative remaining length#687
Merged
cowtowncoder merged 3 commits intoFasterXML:2.21from Apr 9, 2026
Merged
Fix _finishLongTextAscii returning negative remaining length#687cowtowncoder merged 3 commits intoFasterXML:2.21from
_finishLongTextAscii returning negative remaining length#687cowtowncoder merged 3 commits intoFasterXML:2.21from
Conversation
Member
|
Ok, I think fix needs to against branch |
🧪 Code Coverage Report
|
cowtowncoder
reviewed
Apr 7, 2026
cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/parse/CBORLongAsciiRead686Test.java
Show resolved
Hide resolved
Member
|
Aside from re-creating PR against Once we have it, I can proceed with merging & CLA is good for all future contributions. Thank you again -- looking forward to merging the fix! |
cowtowncoder
added
the
cla-needed
`return len - outPtr` was wrong when `outPtr` accumulated across multiple outer-loop iterations: `len` had already been decremented for previous iterations, so subtracting the full `outPtr` produced a negative value, causing `_finishLongText` to skip decoding the non-ASCII byte. Fix: use `return len - _inputPtr`, which holds only the bytes consumed in the current iteration.
hisener
force-pushed
the
halil.sener/gh-issue-686
branch
from
e020aa5 to
def2272
Compare
Contributor
Author
|
Addressed the comment and rebased onto 2.21. Also sent the CLA email. |
cowtowncoder
added
cla-received
Member
|
Thank you, @hisener ! Fix merged in, will be in 2.21.3 and 3.1.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return len - outPtrwas wrong whenoutPtraccumulated across multiple outer-loop iterations:lenhad already been decremented for previous iterations, so subtracting the fulloutPtrproduced a negative value, causing_finishLongTextto skip decoding the non-ASCII byte.Fix: use
return len - _inputPtr, which holds only the bytes consumed in the current iteration.Fixes #686.