Fix ignored snprintf return value in StatusArg.cpp#8967
Open
annafilimonova1 wants to merge 3 commits intoFirebirdSQL:masterfrom
Open
Fix ignored snprintf return value in StatusArg.cpp#8967annafilimonova1 wants to merge 3 commits intoFirebirdSQL:masterfrom
annafilimonova1 wants to merge 3 commits intoFirebirdSQL:masterfrom
Conversation
aafemt
reviewed
Mar 30, 2026
| } | ||
|
|
||
| Quad::Quad(const ISC_QUAD* quad) noexcept : | ||
| Str(text) | ||
| { | ||
| snprintf(text, sizeof(text), "%x:%x", quad->gds_quad_high, quad->gds_quad_low); | ||
| [[maybe_unused]] auto result = snprintf(text, sizeof(text), "%x:%x", | ||
| static_cast<unsigned int>(quad->gds_quad_high), |
Contributor
There was a problem hiding this comment.
Format is hexadecimal. What's wrong with signed integer?
| @@ -407,19 +407,25 @@ Num::Num(ISC_STATUS s) noexcept : | |||
| Int64::Int64(SINT64 val) noexcept : | |||
| Str(text) | |||
| { | |||
| snprintf(text, sizeof(text), "%" SQUADFORMAT, val); | |||
| [[maybe_unused]] auto result = snprintf(text, sizeof(text), "%" SQUADFORMAT, val); | |||
| fb_assert(result >= 0); | |||
| } | |||
Member
There was a problem hiding this comment.
Adding asserts is good idea - but they should be complete. Look here:
From man:
The functions snprintf() and vsnprintf() do not write more than size bytes (including the terminating null byte ('\0')). If the output was truncated due to this limit, then the return value is the number of characters (excluding the terminating null byte) which would have been written to the final string if enough space had been available. Thus, a return value of size or more means that the output was truncated.
I.e. sizeof(text) should also be taken into an account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of closed #8938