Skip to content

[Edicion] Se agregan propiedades para reflejar correctamente el estado devuelvo por el SAT #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mendozagit merged 4 commits into from
Mar 24, 2026
Merged

[Edicion] Se agregan propiedades para reflejar correctamente el estado devuelvo por el SAT #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f76acc
[Edicion] Se agregan propiedades para reflejar correctamente el estad…
mtnadb Feb 16, 2026
c60ff75
[Edicion] Comentarios sobre variables.
mtnadb Feb 17, 2026
53178d8
Se aplican cambios para reflejar nombres correctos de variables y mar…
mtnadb Mar 24, 2026
17b15b5
Merge branch 'FiscalAPI:main' into feature/complete-sat-status-model
mtnadb Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Verify/Models/VerifyResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* ============================================================================
*/

using Fiscalapi.XmlDownloader.Common.Enums;
using Fiscalapi.XmlDownloader.Common.Http;

namespace Fiscalapi.XmlDownloader.Verify.Models;
Expand Down Expand Up @@ -42,4 +43,26 @@ public class VerifyResponse : BaseResponse
/// Indicates if the request is ready for download
/// </summary>
public bool IsReadyToDownload => RequestStatus == RequestStatus.Terminada && InvoiceCount > 0;

/// <summary>
/// Operation status code from the SAT service
/// </summary>
[Obsolete("Use RequestSatStatus instead.")]
public SatStatus SatStatus { get; set; } = new();

/// <summary>
/// Sat 'CodEstatus' received from the service
/// </summary>
[Obsolete("Use RequestSatStatusCode instead.")]
public string? SatStatusCode { get; set; } = new("");

/// <summary>
/// Operation status code from the SAT verification service
/// </summary>
public SatStatus RequestSatStatus { get; set; }

/// <summary>
/// Sat 'CodigoEstadoSolicitud' received from the service
/// </summary>
public string? RequestSatStatusCode { get; set; }
}
11 changes: 11 additions & 0 deletions Verify/VerifyResponseService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ public static VerifyResponse Build(SatResponse satResponse, ILogger logger)
? codEstatus.ToEnumElement<SatStatus>()
: SatStatus.Unknown;

var codSatStatus = envelope?.Body.VerifyDownloadRequestResponse
.VerifyDownloadRequestResult.CodigoEstadoSolicitud;

var satStatus = !string.IsNullOrWhiteSpace(codSatStatus)
? codSatStatus.ToEnumElement<SatStatus>()
: SatStatus.Unknown;

// EstadoSolicitud="3"
var estadoSolicitud = envelope?.Body.VerifyDownloadRequestResponse
.VerifyDownloadRequestResult.EstadoSolicitud;
Expand Down Expand Up @@ -96,6 +103,8 @@ public static VerifyResponse Build(SatResponse satResponse, ILogger logger)
Succeeded = true,
SatStatus = status,
SatStatusCode = status.ToEnumCode(),
RequestSatStatus = satStatus,
RequestSatStatusCode = satStatus.ToEnumCode(),
SatMessage = mensaje,
RequestStatus = requestStatus,
InvoiceCount = invoiceCount,
Expand All @@ -112,6 +121,8 @@ public static VerifyResponse Build(SatResponse satResponse, ILogger logger)
SatMessage = $"StatusCode: {satResponse.HttpStatusCode} Message: {satResponse.ReasonPhrase}",
RawRequest = satResponse.RawRequest,
RawResponse = satResponse.RawResponse,
RequestSatStatus = SatStatus.Unknown,
RequestSatStatusCode = "UnknownError"
};
}
}