Open
Conversation
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
…ent-feature-state-view # Conflicts: # frontend/web/components/modals/AssociatedSegmentOverrides.js
…ent-feature-state-view
# Conflicts: # frontend/web/components/feature-summary/FeatureTags.tsx # frontend/web/components/pages/UserPage.tsx
…ent-feature-state-view # Conflicts: # frontend/common/stores/feature-list-store.ts # frontend/web/components/modals/AssociatedSegmentOverrides.js # frontend/web/components/segments/Rule/components/RuleConditionValueInput.tsx
# Conflicts: # frontend/common/constants.ts # frontend/common/providers/Permission.tsx # frontend/common/types/permissions.types.ts # frontend/common/utils/utils.tsx # frontend/web/components/RolesTable.tsx # frontend/web/components/ServerSideSDKKeys.js # frontend/web/components/import-export/ImportPage.tsx # frontend/web/components/modals/CreateSegmentRulesTabForm.tsx # frontend/web/components/modals/create-feature/index.js # frontend/web/components/modals/create-feature/tabs/CreateFeatureTab.tsx # frontend/web/components/modals/create-feature/tabs/FeatureSettingsTab.tsx # frontend/web/components/modals/create-feature/tabs/FeatureValue.tsx # frontend/web/components/navigation/navbars/ProjectNavbar.tsx # frontend/web/components/pages/IntegrationsPage.tsx # frontend/web/components/pages/OrganisationIntegrationsPage.tsx # frontend/web/components/pages/UsersAndPermissionsPage.tsx # frontend/web/components/pages/UsersPage.tsx # frontend/web/components/pages/features/components/FeaturesPageHeader.tsx
Member
Author
|
Good spot RE those @talissoncosta. I think we need to sort this out project-wide, more things are starting to use environment.id vs api_key. We should start a convention that explicitly states environmentAPIKey rather than environmentId in the cases we're using the api_key string. I'll take a look at tackling this in a followup PR separate to this. |
# Conflicts: # frontend/web/components/modals/create-feature/index.js
Replace manual _data.get() calls and useCallback paging logic with useGetIdentityOverridesQuery and useCreateIdentityOverrideMutation. Permission check for edge identities now uses useHasPermission hook. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Vertically align Edit and delete buttons - Move enabled switch to right of remote config value - Add margin to identifier and Edit button - Trigger FeatureListStore saved event on create/delete to refresh FeaturesPage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
talissoncosta
approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Looks good — all feedback addressed. The environment ID bugs in IdentityOverridesTab and SegmentOverridesTab are fixed.
Thanks so much for the hard work on it @kyle-ssg
Contributor
Totally agree! Thanks for that @kyle-ssg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Migrates all tabs including the create feature modal itself to TypeScript, no type errors to do with creating / editing a feature and also reduces the feature modal by ~1200 LoC.
Migrates a few components to ES export
How did you test this code?