Skip to content

fix the links with sed between endpoint listing and endpoint details#1753

Open
nhoening wants to merge 16 commits intomainfrom
fix/api-links-in-RTD
Open

fix the links with sed between endpoint listing and endpoint details#1753
nhoening wants to merge 16 commits intomainfrom
fix/api-links-in-RTD

Conversation

@nhoening
Copy link
Copy Markdown
Contributor

@nhoening nhoening commented Oct 15, 2025

This was a left-over from #1703

Description

  • fix links after RTD builds the docs
  • Added changelog item in documentation/changelog.rst

…nt details (open-api-style)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added the documentation Improvements or additions to documentation label Oct 15, 2025
@nhoening nhoening added this to the 0.30.0 milestone Oct 15, 2025
@nhoening nhoening self-assigned this Oct 15, 2025
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening added a commit that referenced this pull request Dec 1, 2025
…one, others fix the brackets distinction (see also #1753)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening added a commit that referenced this pull request Dec 2, 2025
* fix a few links to API endpoints in the tutorial - one was the wrong one, others fix the brackets distinction (see also #1753)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* update some moore links in several tutorials so they do point to the rght anchor again

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add changelog entry

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

---------

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening modified the milestones: 0.30.0, 0.31.0 Dec 2, 2025
@nhoening nhoening modified the milestones: 0.31.0, 0.32 Mar 1, 2026
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Copy link
Copy Markdown
Contributor Author

@copilot for some reason, this new command correctly does the replacement in the generated .rst files on my local unix environment, but not in the ReadTheDocs environment. Do you have an idea why?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

5 similar comments
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17eff88e-e999-44d4-b144-ee0f39c46dfa

Sorry for the inconvenience!

@nhoening nhoening modified the milestones: 0.32.0, 0.33.0 Apr 14, 2026
@nhoening
Copy link
Copy Markdown
Contributor Author

@copilot please try again

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

4 similar comments
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@nhoening Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 76078448-5669-4080-bd71-9a0aba9bb560

Sorry for the inconvenience!

@Flix6x
Copy link
Copy Markdown
Contributor

Flix6x commented Apr 14, 2026

@copilot please address the comments of @nhoening.

Copilot AI and others added 2 commits April 14, 2026 17:28
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@copilot for some reason, this new command correctly does the replacement in the generated .rst files on my local unix environment, but not in the ReadTheDocs environment. Do you have an idea why?

Likely because RTD can emit a different output layout than your local build (api/v3_0/index.html instead of api/v3_0.html), so the previous replacement hit a non-existent file there. I replaced the sed step with a portable Python post-build patch that checks both paths and rewrites whichever exists (commit 58198186).

@copilot please try again

Done. I retried and fixed the RTD post-build replacement to be path-robust and portable, plus explicit error handling when no target file exists (commit 58198186).

@copilot please address the comments of @nhoening.

Addressed. I updated the ReadTheDocs replacement step to handle both API output path variants and made failure explicit if neither file exists (commit 58198186).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.python.org
    • Triggering command: /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/sphinx-build sphinx-build -b html documentation documentation/_build/html -W --keep-going -n c581053f8d84a70fd4e262adcace5a95a5b/log.json c54fb2088a74ff4f/usr/bin/runc (dns block)
    • Triggering command: /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/sphinx-build sphinx-build -b html documentation documentation/_build/html -W --keep-going -n c581053f8d84a70fd4e262adcace5a95a5b/log.json by/55732208d1f73--root 262adcace5a95a5b/var/run/docker/runtime-runc/moby 492332f2cdd1a463--log /usr�� --root /var/run/docker/json c54fb2088a74ff4f--systemd-cgroup by/ddbae0e2502be/usr/lib/postgresql/17/bin/pg_isready c581053f8d84a70fd4e262adcace5a95a5b/14a2eecb24026f512a0da3be83fc83b65e41e1d8e4533aa7e3c082ca03e7--log 262adcace5a95a5b/tmp/runc-process679443601 10da8379180815d6--detach (dns block)
  • flexmeasures.readthedocs.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
    • Triggering command: /usr/bin/curl curl -I -L --max-time 20 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from Flix6x April 14, 2026 17:32
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 14, 2026

Documentation build overview

📚 flexmeasures | 🛠️ Build #32302048 | 📁 Comparing 048d163 against latest (f3008b2)

  🔍 Preview build  

4 files changed
± changelog.html
± _autosummary/flexmeasures.api.v3_0.sensors.html
± api/change_log.html
± api/v3_0.html

@nhoening
Copy link
Copy Markdown
Contributor Author

nhoening commented Apr 16, 2026

This works. To test, visit api/v3_0.html and click links with an ID.

@copilot I want two changes:

  • let's not raise an error if no file is found, but instead print a warning.
  • merge main and add a changelog header for version 0.33.0

@nhoening
Copy link
Copy Markdown
Contributor Author

@Flix6x I am not a reviewer on this PR - mabye you can ask for my two requests?

@Flix6x
Copy link
Copy Markdown
Contributor

Flix6x commented Apr 17, 2026

Haha this is my job now. Conveying my colleague's requests to @copilot.

Copilot AI and others added 3 commits April 17, 2026 06:49
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

This works. To test, visit api/v3_0.html and click links with an ID.

@copilot I want two changes:
...

Implemented both requests. I changed the RTD post-build step to emit a warning (to stderr) instead of raising when no target file is found (8adcf12a), and merged latest main into this branch (8f0120e5), which brings in the v0.33.0 changelog header.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.python.org
    • Triggering command: /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/python3 /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/python3 -m sphinx -b html documentation /tmp/fm-docs-before (dns block)
    • Triggering command: /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/python3 /home/REDACTED/work/flexmeasures/flexmeasures/.venv/bin/python3 -m sphinx -b html documentation /tmp/fm-docs-after by/f490f025ae8e7fb5899263f5bf1226a62a7fc8099cccd57013bf908aab1c9a60/log.json fb5899263f5bf122grep c9db2c971f47e7f2-q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Flix6x
Copy link
Copy Markdown
Contributor

Flix6x commented Apr 17, 2026

@copilot write the changelog entry is what was meant.

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

@copilot write the changelog entry is what was meant.

Added the changelog entry under v0.33.0Bugfixes for this RTD endpoint-link fix in commit 048d1634.
Screenshot: N/A (documentation-only change, no UI changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants