Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6863 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 399 399
Lines 20159 20159
Branches 4855 4855
=======================================
Hits 15451 15451
Misses 4708 4708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
please address the merge conflicts |
cstns
left a comment
cstns
left a comment
There was a problem hiding this comment.
Looking good!
I don't like the try/catch approach in the stores module though, would like to explore alternatives
| // Update in PR 12 (product-expert) to use Pinia store imports directly. | ||
| expert (state) { | ||
| // Use require() to avoid circular module dependencies at load time. | ||
| // Falls back to safe defaults when the Vuex store is unavailable (e.g. isolated unit tests). |
There was a problem hiding this comment.
a different approach should be taken here, we should not be altering functionality to suit testing but the other way round
There was a problem hiding this comment.
So we do remove this within Task 11 it just becomes:
const account = useAccountBridge()
This is a temporary workaround since we are split between Vuex and Pinia so I figured it would be okay for now. Lmk your thoughts.
2 participants
Description
See test plan and details.
Related Issue(s)
Resolves #6822
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel