Feature: Version 2.x reintroduce disabling nodes (_hidden=true)#55
Open
Feature: Version 2.x reintroduce disabling nodes (_hidden=true)#55
_hidden=true)#55Conversation
Contributor
Author
|
With the introduction of subtreetags in Neos9 we could also introduce a 'Flowpack.NodeTemplates:Content.Hidden':
superTypes:
'Neos.Neos:Content': true
options:
template:
disabled: true
# alternative
subtreetags:
disabled: true
properties:
someProperty: "value" |
This reverts commit 4fa4f45.
0f95072 to
9a6933b
Compare
_hidden=true)
9a6933b to
4ed8487
Compare
- introduce $showDisabledNodesInSubgraph in tests to show disabled created nodes - introduce `NodeMutator::setDisabled` - updated all snapshots to include `"disabled": false,`
4ed8487 to
c682516
Compare
Contributor
Author
|
I started a voting in slack regarding the syntax: option1 1️⃣, first level disabled (no support for custom subtreetags) option2 2️⃣, nested tags , to also allow custom SubtreeTags in Neos9 option3 3️⃣ , allow both tags and disabled: true first level (basically option1 and option2 combined) we voted with 6 votes for option2 2️⃣ |
…ee tags and allow `tags.disabled` in Neos 8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With pr the functionality to set internal node properties via
_fooproperty syntax, which was introduced with was reverted. This was done in preparation for the Neos 9 ESCR to be forwards compatible.The most requested internal property
properties._hiddenis now available viatags.disabled.- The idea of tags is back-ported from Neos 9 where the Node will be tagged as
disabledor possibly a custom value. See SubtreeTags. Naturally Neos 8.3 can only support the disabled/hidden case and thus other values will throw an exception.- The name shift from
hiddentodisabledwas done to adjust to the naming of the new ESCR. See explanation.This is WIP as the naming of usingThats why this was omitted from the Version2 release but once we find a solution we will release a new version with support for this.hiddenvsdisabledis not 100% clear yet.Discussion: neos/neos-development-collection#4312
Regarding the naming of the new option
tags. The term is already partly overloaded and could be mistaken but the reasoning was to align it with the new Neos 9 Api. While more explicit we decided againstsubtreetagsas this term is only used in the cr-write-side and thus more low-level and less know by the integrator. The nametagsas inNode::$tags(seeNodeTags) will be part of the Neos 9 API and hopefully a known and understood concept by the user.https://github.com/neos/neos-development-collection/blob/f640f70321f6a96837dbea86ce1d11c72368c924/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php#L128
see also voting: #55 (comment)