-
Notifications
You must be signed in to change notification settings - Fork 16
CoreML Conversion Patterns & MB-MelGAN Optimization Benchmarks #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-Wengg
wants to merge
17
commits into
main
Choose a base branch
from
tts/cosyvoice3-coreml-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d0d0140
feat(tts): Add complete CosyVoice3 CoreML conversion
Alex-Wengg dedb337
feat(tts): Add CoreML inference pipeline demo
Alex-Wengg da38247
wip(tts): Add CoreML vocoder test pipeline
Alex-Wengg 6d85908
docs(tts): Document Python CoreML loading timeout issue
Alex-Wengg 4bcfe84
docs(tts): Add comprehensive CoreML conversion summary
Alex-Wengg 5eb246d
Add Swift CoreML tests and loading issue analysis
Alex-Wengg a936224
fix(tts): Document vocoder CoreML loading issue and hybrid solution
Alex-Wengg 693eab7
docs(tts): Add comprehensive final resolution summary
Alex-Wengg b17a524
feat(tts): Add stateless ONNX analysis and attempted export
Alex-Wengg 856eb39
docs(tts/cosyvoice3): Add CoreML conversion patterns and MB-MelGAN op…
Alex-Wengg 8b0d3a5
feat(tts/cosyvoice3): Add complete MB-MelGAN fine-tuning pipeline
Alex-Wengg 8b64dd2
refactor: Reorganize coreml/ with docs/, scripts/, benchmarks/ struct…
Alex-Wengg cad2575
chore: Update .gitignore to exclude trial artifacts and only track or…
Alex-Wengg 3d7a098
chore: Remove trial artifacts from git tracking
Alex-Wengg 5cf8804
docs: Restore and organize all trial documentation in trials/ directory
Alex-Wengg bb5b243
docs: Update README to reference trials/ directory
Alex-Wengg 4052040
docs: Add comprehensive RESEARCH_PAPERS.md with citations and bibliog…
Alex-Wengg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Python | ||
| __pycache__/ | ||
| *.pyc | ||
| .venv/ | ||
| *.egg-info/ | ||
| venv_*/ | ||
|
|
||
| # Dependencies | ||
| uv.lock | ||
|
|
||
| # Logs | ||
| *.log | ||
|
|
||
| # Generated audio | ||
| *.wav | ||
|
|
||
| # Generated data | ||
| mbmelgan_training_data/ | ||
| mbmelgan_quickstart/ | ||
| mbmelgan_pretrained/ | ||
| precision_test/ | ||
| rangedim_test/ | ||
| rangedim_quickstart_test/ | ||
| mbmelgan_quality_test/ | ||
| mbmelgan_standalone_test/ | ||
| pretrained_models/ | ||
|
|
||
| # Compiled CoreML models (regenerate from .mlpackage) | ||
| *.mlmodelc/ | ||
| *.mlpackage/ | ||
|
|
||
| # Build artifacts | ||
| compiled/ | ||
| converted/ | ||
| decoder_layers/ | ||
|
|
||
| # Trial/research files in root (organized in trials/ directory) | ||
| # Keep only: docs/, scripts/, benchmarks/, trials/, README.md, pyproject.toml | ||
| /*.md | ||
| !README.md | ||
| /*.py | ||
| /*.swift | ||
| /*.sh | ||
| /*.pid | ||
| /*.txt | ||
| cosyvoice_repo/ | ||
| CosyVoiceSwift/ | ||
| ParallelWaveGAN/ | ||
| fargan_source/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 .gitignore excludes uv.lock, violating repo convention for reproducible builds
The
.gitignoreat line 9 ignoresuv.lock. AGENTS.md and CLAUDE.md both state that each target directory is self-contained with its ownpyproject.toml(and implicitlyuv.lock). Every othercoreml/target directory in the repo commits itsuv.lock(e.g.,models/vad/silero-vad/coreml/uv.lock,models/tts/kokoro/coreml/uv.lock,models/tts/qwen3/coreml/uv.lock, etc.). Excludinguv.lockbreaks reproducible dependency resolution, which is a core requirement ofuv-based workflows.Was this helpful? React with 👍 or 👎 to provide feedback.