Skip to content

fix(ci): resolve reusable docker workflow-file evaluation error#3

Merged
LucasSantana-Dev merged 1 commit intomainfrom
fix/reusable-docker-secrets-if
Mar 10, 2026
Merged

fix(ci): resolve reusable docker workflow-file evaluation error#3
LucasSantana-Dev merged 1 commit intomainfrom
fix/reusable-docker-secrets-if

Conversation

@LucasSantana-Dev
Copy link
Member

@LucasSantana-Dev LucasSantana-Dev commented Mar 10, 2026

Summary

  • fix .github/workflows/reusable-docker-build.yml workflow-file failure on push
  • root cause from run 22829586601: if expression referenced secrets.DOCKER_USERNAME, which is invalid in workflow expression evaluation
  • switch guard to env-backed check and keep secret values in step env/with

Changes

  • update Docker Hub login guard in reusable docker workflow
  • add changelog entry for this CI fix
  • add README maintenance note

Validation

  • confirmed no secrets.* usage remains in if conditions for this workflow
  • rendered workflow YAML successfully via gh workflow view reusable-docker-build.yml --yaml

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Docker Hub authentication in the CI/CD pipeline to prevent workflow execution errors.
  • Documentation

    • Added CHANGELOG documenting repository changes using Keep a Changelog format.
    • Updated README with maintenance notes on CI/CD improvements.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3a544c77-747e-4904-ae71-9df55f8996bd

📥 Commits

Reviewing files that changed from the base of the PR and between 6fbe56b and 979e05c.

📒 Files selected for processing (3)
  • .github/workflows/reusable-docker-build.yml
  • CHANGELOG.md
  • README.md

📝 Walkthrough

Walkthrough

The workflow configuration is refactored to use environment variables (DOCKER_USERNAME, DOCKER_PASSWORD) sourced from secrets instead of directly referencing secrets in conditional statements. This prevents workflow evaluation errors. Documentation files are added and updated to record this change.

Changes

Cohort / File(s) Summary
Workflow Refactoring
.github/workflows/reusable-docker-build.yml
Replaces direct secrets.* references in Docker Hub login conditional checks and steps with environment-backed env.DOCKER_USERNAME and env.DOCKER_PASSWORD variables sourced from secrets, preventing workflow evaluation errors.
Documentation
CHANGELOG.md, README.md
Introduces CHANGELOG.md with Keep a Changelog format documenting the workflow fix in Unreleased → Fixed section. Updates README.md with a maintenance note describing the secrets reference fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 Hops with joy at secrets contained,
No more errors in workflows strained,
Environment variables take the lead,
Docker Hub credentials now flow with speed,
A bugfix done, the rabbit's creed! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing a workflow-file evaluation error in the reusable Docker workflow by addressing invalid secrets context usage in if conditions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/reusable-docker-secrets-if

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LucasSantana-Dev LucasSantana-Dev merged commit 17797b9 into main Mar 10, 2026
2 checks passed
@LucasSantana-Dev LucasSantana-Dev deleted the fix/reusable-docker-secrets-if branch March 10, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant