Open
Conversation
added 2 commits
October 20, 2020 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started this PR to add some basic tests to the library in the hope that you're happy with the initial approach and I can add some more. I find the functionality really useful and hope that by adding some tests to it then confidence in the library will increase in the wider dev community.
Some parts of the library I'm finding hard to test and could be refactored into smaller functions if you're happy for me to do that where it makes sense to. For example, in the main init function I couldn't simulate it serving the callback.html file but that may be a limitation of my testing experience rather than a hard limit! Because of that though I've only tested side-effects and that the shape is consistent so far. Another example is in the appAuthHelperFetchTokens where it initialises and can only be tested by jest once because of the way the function self executes but if an 'init' function or similar is added then writing multiple tests for it would be simpler.
Let me know what you think 😀