-
Notifications
You must be signed in to change notification settings - Fork 3
chore(deps): update dependency msw to v2.12.9 #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 969e3cc
☁️ Nx Cloud last updated this comment at |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.84%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 18.79% 18.84% +0.05%
==========================================
Files 140 142 +2
Lines 27640 27773 +133
Branches 980 993 +13
==========================================
+ Hits 5195 5234 +39
- Misses 22445 22539 +94 🚀 New features to boost your workflow:
|
|
Deployed 2f13045 to https://ForgeRock.github.io/ping-javascript-sdk/pr-529/2f13045b208f7845e6d187b17eb89c8157ae8865 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-83.3 KB, -100.0%) 📊 Minor Changes📉 @forgerock/journey-client - 83.3 KB (-0.0 KB) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
0cfb72f to
969e3cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
We've added a 5-second wait after page navigation in the PingAM logout test to ensure the OIDC client's wellknown configuration fetch completes before attempting authorization. The msw update from 2.12.1 to 2.12.9 introduced timing changes in request interception that caused a race condition where the authorization attempt occurred before the wellknown data was stored in Redux, resulting in "Wellknown missing authorization endpoint" errors and test timeouts.
Tip
✅ We verified this fix by re-running @forgerock/oidc-suites:e2e-ci--src/logout.spec.ts.
diff --git a/e2e/oidc-suites/src/logout.spec.ts b/e2e/oidc-suites/src/logout.spec.ts
index ae406530..779eddbd 100644
--- a/e2e/oidc-suites/src/logout.spec.ts
+++ b/e2e/oidc-suites/src/logout.spec.ts
@@ -34,6 +34,10 @@ test.describe('Logout tests', () => {
}
});
+ // Wait for the OIDC client to fully initialize
+ // The msw 2.12.9 update may have introduced timing changes in request interception
+ await page.waitForTimeout(5000);
+
await clickWithRedirect('Login (Background)', '**/am/XUI/**');
await page.getByLabel('User Name').fill(pingAmUsername);
Or Apply changes locally with:
npx nx-cloud apply-locally XGN2-rvnh
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This PR contains the following updates:
2.12.1→2.12.9Release Notes
mswjs/msw (msw)
v2.12.9Compare Source
v2.12.9 (2026-02-06)
Bug Fixes
ws.link(#2661) (2f1d23c) @kettanaitov2.12.8Compare Source
v2.12.8 (2026-02-03)
Bug Fixes
@mswjs/interceptorsto fix a memory leak (#2659) (e5e905f) @kettanaitorettime(#2657) (3a7b451) @kettanaitov2.12.7Compare Source
v2.12.7 (2025-12-27)
Bug Fixes
GraphQLLinkHandlerstype (#2647) (cfab780) @kettanaitoTypedDocumentStringas request predicate (#2646) (494d5e8) @kettanaitoDocumentNodeunion (#2645) (0f6e28f) @kettanaitov2.12.6Compare Source
v2.12.6 (2025-12-26)
Bug Fixes
quietoption (#2644) (d50f73e) @kettanaitov2.12.5Compare Source
v2.12.5 (2025-12-26)
Bug Fixes
1266f61) @BSteffaniak @kettanaitov2.12.4Compare Source
v2.12.4 (2025-12-03)
Bug Fixes
localStoragein Node.js v25 (#2636) (3da2c76) @rvaggv2.12.3Compare Source
v2.12.3 (2025-11-23)
Bug Fixes
HttpHandler(#2560) (1af6cee) @SerkanSipahi @kettanaito9efe103) @kettanaito18d7d3d) @Enet4 @kettanaitov2.12.2Compare Source
v2.12.2 (2025-11-14)
Bug Fixes
browserandreact-nativeexport conditions lower (#2627) (102d85a) @vidschofelixConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.