Skip to content

fix(ci): disable lefthook in publish workflow#570

Open
ryanbas21 wants to merge 1 commit intomainfrom
fix/disable-lefthook-in-ci
Open

fix(ci): disable lefthook in publish workflow#570
ryanbas21 wants to merge 1 commit intomainfrom
fix/disable-lefthook-in-ci

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

Summary

  • Adds LEFTHOOK=0 to the publish-or-pr job so changesets' version commit doesn't trigger lefthook pre-commit hooks in CI
  • Replaces stale HUSKY=0 with LEFTHOOK=0 in the snapshot job

Context

Merging #564 triggered the publish workflow, where changesets ran git commit to version packages. This fired lefthook's pre-commit hook which runs nx affected — but there's no Nx Cloud DTE agent context for that secondary commit, causing CI to fail.

Fixes: https://github.com/ForgeRock/ping-javascript-sdk/actions/runs/24483747421/job/71553933332

Test plan

  • Merge to main and verify the publish workflow succeeds
  • Verify the Release PR is created/updated correctly by changesets

Changesets action commits version bumps which triggers lefthook's
pre-commit hook in CI. The hook runs nx affected which fails without
an Nx Cloud DTE agent context. Setting LEFTHOOK=0 skips hooks for
all git operations in the publish jobs.

Also replaces stale HUSKY=0 with LEFTHOOK=0 in the snapshot job.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

⚠️ No Changeset found

Latest commit: 6c8d395

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Warning

Rate limit exceeded

@ryanbas21 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 11 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 11 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 32197a04-036d-4f17-8315-d2ce72094437

📥 Commits

Reviewing files that changed from the base of the PR and between 7a45452 and 6c8d395.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/disable-lefthook-in-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Apr 15, 2026

View your CI Pipeline Execution ↗ for commit 6c8d395

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 7m 44s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-15 23:54:48 UTC

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.67%. Comparing base (5d6747a) to head (6c8d395).
⚠️ Report is 28 commits behind head on main.

❌ Your project status has failed because the head coverage (15.67%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #570       +/-   ##
===========================================
- Coverage   70.90%   15.67%   -55.24%     
===========================================
  Files          53      154      +101     
  Lines        2021    26666    +24645     
  Branches      377     1127      +750     
===========================================
+ Hits         1433     4180     +2747     
- Misses        588    22486    +21898     

see 101 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 15, 2026

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@570

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@570

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@570

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@570

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@570

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@570

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@570

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@570

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@570

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@570

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@570

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@570

commit: 6c8d395

@github-actions
Copy link
Copy Markdown
Contributor

Deployed 1b565a9 to https://ForgeRock.github.io/ping-javascript-sdk/pr-570/1b565a9df89dfd6fff5a7c712771a6008bb7a695 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-9.7 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-89.2 KB, -100.0%)

📊 Minor Changes

📈 @forgerock/device-client - 9.9 KB (+0.2 KB)
📉 @forgerock/davinci-client - 48.0 KB (-0.0 KB)
📈 @forgerock/oidc-client - 25.2 KB (+0.3 KB)
📈 @forgerock/journey-client - 89.9 KB (+0.7 KB)

➖ No Changes

@forgerock/sdk-utilities - 11.2 KB
@forgerock/sdk-types - 7.9 KB
@forgerock/protect - 150.1 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-oidc - 4.8 KB
@forgerock/sdk-request-middleware - 4.5 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/iframe-manager - 2.4 KB


14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants