Adds instructions for using custom langauges with Next.js#202
Adds instructions for using custom langauges with Next.js#202kochie wants to merge 4 commits intoFormidableLabs:masterfrom
Conversation
|
Any update on this one? |
|
Legit forgot about this. @gksander anything I can do to close this out? edit: I've just fixed the merge conflict. |
| ]) | ||
|
|
||
| const CodeBlock({code, language}) { | ||
| use(ExtraLanguages) |
There was a problem hiding this comment.
Is use a generally available function yet, or still in canary?
| import CodeBlock, { CodeBlockProps } from './codeblock' | ||
| import { PropsWithChildren, Suspense } from 'react' | ||
|
|
||
| ;(typeof global !== 'undefined' ? global : window).Prism = Prism |
There was a problem hiding this comment.
I like the idea of using suspense, but placing Prism in the globals might be counter to what we are trying to do in this library, which is avoid polluting the global namespace.
There was a problem hiding this comment.
Using suspense makes the component client-only though, it means built-in languages will be rendered server-side, but extra languages will need JS on the client to work.
Personally I would like this library to work completely on the server, like Bright does.
There was a problem hiding this comment.
Also, this should be called on the client side component along the server one.
| import('prismjs/components/prism-julia'), | ||
| ]) | ||
|
|
||
| const CodeBlock({code, language}) { |
There was a problem hiding this comment.
| const CodeBlock({code, language}) { | |
| const CodeBlock = ({code, language}) => { | |
No description provided.