refactor: remove DocumentApi type and anything that depended on it#1456
Merged
refactor: remove DocumentApi type and anything that depended on it#1456
Conversation
🦋 Changeset detectedLatest commit: 70cbd34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ragi96
reviewed
Mar 10, 2026
| * @deprecated will be removed in version 4.0.0 of `@frontify/app-bridge` | ||
| * There won't be a replacement for this method. But Link Chooser will be in-sourced and there will be a command to open it. | ||
| */ | ||
| getDocumentsByDocumentGroupId(documentGroupId: number): Promise<Document[]>; |
Collaborator
There was a problem hiding this comment.
Here you need a follow up in the web-app as we need to move it to v3, similar to what I did here:
ragi96
reviewed
Mar 10, 2026
* remove DocumentApiDummy and DocumentDummy testing utils * cleanup Document.ts types * remove `getDocumentsByDocumentGroupId` from AppBridgeBlock
Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com>
Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com>
Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com>
peter-tudosa
force-pushed
the
CU-869ccq13g_v4-refactor-Document_Peter-Tudosa
branch
from
168caeb to
06ba798
Compare
Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com>
|
ragi96
approved these changes
Mar 12, 2026
Collaborator
ragi96
left a comment
ragi96
left a comment
There was a problem hiding this comment.
V3 still works, great work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDocumentsByDocumentGroupIdfrom AppBridgeBlock