Skip to content

rust: Upgrade to HTTP API#929

Merged
GermanCoding merged 8 commits intomainfrom
rust/http-api
Feb 27, 2026
Merged

rust: Upgrade to HTTP API#929
GermanCoding merged 8 commits intomainfrom
rust/http-api

Conversation

@GermanCoding
Copy link
Copy Markdown
Collaborator

No description provided.

Bring Rust up to speed again, now with 50% <s>more</s>less bugs!
@secana
Copy link
Copy Markdown
Member

secana commented Feb 24, 2026

In the justfile it has to be:

populate-rust-env:
  cp .env.https rust/.env

Else the old WSS env vars are taken and the tests fails.

EDIT: I fixed it to proceed with the tests and review.

@secana
Copy link
Copy Markdown
Member

secana commented Feb 24, 2026

Overall: Greate PR! The HTTP API is much easier than the old WSS. Very clean und readable code!

  • I skimped over the code, it's a lot but looks good
  • I ran all tests with just test-rust

Issue: When using it in gdcli to scan a a few thousand files it dies with 2026-02-24T08:25:31.343799Z WARN gdcli: Failed to get scan result: VaaS error: Request was canceled. Could be the API hammering or our servers not beeing able to handle many files? So maybe not an issue in the vaas sdk but in the client/server that needs to back up if there are too many files in the processing. I did not have this with the wss API, though.

Comment thread rust/src/vaas.rs
Comment thread rust/src/vaas.rs
Comment thread rust/src/vaas.rs
Comment thread .github/workflows/ci-rust.yaml Outdated
Comment thread .github/workflows/ci-rust.yaml Outdated
Comment thread .github/workflows/ci-rust.yaml Outdated
Comment thread rust/src/message/problem.rs Outdated
Comment thread rust/src/authentication/secret_string.rs
Comment thread rust/tests/real_api_integration_tests.rs Outdated
Comment thread rust/tests/real_api_integration_tests.rs Outdated
@GermanCoding
Copy link
Copy Markdown
Collaborator Author

Issue: When using it in gdcli to scan a a few thousand files it dies with 2026-02-24T08:25:31.343799Z WARN gdcli: Failed to get scan result: VaaS error: Request was canceled. Could be the API hammering or our servers not beeing able to handle many files? So maybe not an issue in the vaas sdk but in the client/server that needs to back up if there are too many files in the processing. I did not have this with the wss API, though.

Request was canceled is a client-side error triggered by the client's CancellationToken requesting cancel. Many simultaneous requests may cause delays in individual scans, if you're canceling requests quickly this may happen before analysis completes.

@secana
Copy link
Copy Markdown
Member

secana commented Feb 26, 2026

From my perspective you can squash and merge this PR. It's a breaking change as the authentication methods changed, so a major version bump seems appropriate.

@GermanCoding GermanCoding merged commit 5d1a366 into main Feb 27, 2026
@GermanCoding GermanCoding deleted the rust/http-api branch February 27, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants